[IPv6] route: Simplify ip6_del_rt()

Provide a simple ip6_del_rt() for the majority of users and
an alternative for the exception via netlink. Avoids code
obfuscation.

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 12 insertions, 6 deletions

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 1aca787ead85..8d511de0db1b 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -457,7 +457,7 @@ int rt6_route_rcv(struct net_device *dev, u8 *opt, int len,
         rt = rt6_get_route_info(prefix, rinfo->prefix_len, gwaddr, dev->ifindex);
 
         if (rt && !lifetime) {
-                ip6_del_rt(rt, NULL, NULL, NULL);
+                ip6_del_rt(rt);
                 rt = NULL;
         }
 
@@ -813,7 +813,7 @@ static struct dst_entry *ip6_negative_advice(struct dst_entry *dst)
 
         if (rt) {
                 if (rt->rt6i_flags & RTF_CACHE)
-                        ip6_del_rt(rt, NULL, NULL, NULL);
+                        ip6_del_rt(rt);
                 else
                         dst_release(dst);
         }
@@ -1218,7 +1218,8 @@ out:
         return err;
 }
 
-int ip6_del_rt(struct rt6_info *rt, struct nlmsghdr *nlh, void *_rtattr, struct netlink_skb_parms *req)
+static int __ip6_del_rt(struct rt6_info *rt, struct nlmsghdr *nlh,
+                        void *_rtattr, struct netlink_skb_parms *req)
 {
         int err;
         struct fib6_table *table;
@@ -1237,6 +1238,11 @@ int ip6_del_rt(struct rt6_info *rt, struct nlmsghdr *nlh, void *_rtattr, struct
         return err;
 }
 
+int ip6_del_rt(struct rt6_info *rt)
+{
+        return __ip6_del_rt(rt, NULL, NULL, NULL);
+}
+
 static int ip6_route_del(struct in6_rtmsg *rtmsg, struct nlmsghdr *nlh,
                          void *_rtattr, struct netlink_skb_parms *req,
                          u32 table_id)
@@ -1271,7 +1277,7 @@ static int ip6_route_del(struct in6_rtmsg *rtmsg, struct nlmsghdr *nlh,
                         dst_hold(&rt->u.dst);
                         read_unlock_bh(&table->tb6_lock);
 
-                        return ip6_del_rt(rt, nlh, _rtattr, req);
+                        return __ip6_del_rt(rt, nlh, _rtattr, req);
                 }
         }
         read_unlock_bh(&table->tb6_lock);
@@ -1395,7 +1401,7 @@ restart:
         call_netevent_notifiers(NETEVENT_REDIRECT, &netevent);
 
         if (rt->rt6i_flags&RTF_CACHE) {
-                ip6_del_rt(rt, NULL, NULL, NULL);
+                ip6_del_rt(rt);
                 return;
         }
 
@@ -1631,7 +1637,7 @@ restart:
                 if (rt->rt6i_flags & (RTF_DEFAULT | RTF_ADDRCONF)) {
                         dst_hold(&rt->u.dst);
                         read_unlock_bh(&table->tb6_lock);
-                        ip6_del_rt(rt, NULL, NULL, NULL);
+                        ip6_del_rt(rt);
                         goto restart;
                 }
         }