diff options
author | Lv Liangying <lvly@nanjing-fnst.com> | 2006-08-29 03:00:47 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2006-08-30 00:22:15 -0400 |
commit | 76d0cc1b64e1686b2b53e081c94142dd99f01ec5 (patch) | |
tree | 0ea9e38ef83928e7b990bf0f732809b36b1b53a4 /net/ipv6/route.c | |
parent | 8fb6f732c389847dece403b7470d6d3d2778804a (diff) |
[IPV6]: SNMPv2 "ipv6IfStatsInAddrErrors" counter error
When I tested Linux kernel 2.6.17.7 about statistics
"ipv6IfStatsInAddrErrors", found that this counter couldn't increase
correctly. The criteria is RFC2465:
ipv6IfStatsInAddrErrors OBJECT-TYPE
SYNTAX Counter32
MAX-ACCESS read-only
STATUS current
DESCRIPTION
"The number of input datagrams discarded because
the IPv6 address in their IPv6 header's destination
field was not a valid address to be received at
this entity. This count includes invalid
addresses (e.g., ::0) and unsupported addresses
(e.g., addresses with unallocated prefixes). For
entities which are not IPv6 routers and therefore
do not forward datagrams, this counter includes
datagrams discarded because the destination address
was not a local address."
::= { ipv6IfStatsEntry 5 }
When I send packet to host with destination that is ether invalid
address(::0) or unsupported addresses(1::1), the Linux kernel just
discard the packet, and the counter doesn't increase(in the function
ip6_pkt_discard).
Signed-off-by: Lv Liangying <lvly@nanjing-fnst.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/route.c')
-rw-r--r-- | net/ipv6/route.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 4b163711f3a8..d9baca062d24 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c | |||
@@ -1532,6 +1532,10 @@ int ipv6_route_ioctl(unsigned int cmd, void __user *arg) | |||
1532 | 1532 | ||
1533 | static int ip6_pkt_discard(struct sk_buff *skb) | 1533 | static int ip6_pkt_discard(struct sk_buff *skb) |
1534 | { | 1534 | { |
1535 | int type = ipv6_addr_type(&skb->nh.ipv6h->daddr); | ||
1536 | if (type == IPV6_ADDR_ANY || type == IPV6_ADDR_RESERVED) | ||
1537 | IP6_INC_STATS(IPSTATS_MIB_INADDRERRORS); | ||
1538 | |||
1535 | IP6_INC_STATS(IPSTATS_MIB_OUTNOROUTES); | 1539 | IP6_INC_STATS(IPSTATS_MIB_OUTNOROUTES); |
1536 | icmpv6_send(skb, ICMPV6_DEST_UNREACH, ICMPV6_NOROUTE, 0, skb->dev); | 1540 | icmpv6_send(skb, ICMPV6_DEST_UNREACH, ICMPV6_NOROUTE, 0, skb->dev); |
1537 | kfree_skb(skb); | 1541 | kfree_skb(skb); |