diff options
author | Alexey Dobriyan <adobriyan@gmail.com> | 2010-02-16 04:05:04 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-02-16 17:55:25 -0500 |
commit | d5aa407f59f5b83d2c50ec88f5bf56d40f1f8978 (patch) | |
tree | 664c30873708f0e361e5250835238043200f4b50 /net/ipv6/ip6_tunnel.c | |
parent | c2892f02712e9516d72841d5c019ed6916329794 (diff) |
tunnels: fix netns vs proto registration ordering
Same stuff as in ip_gre patch: receive hook can be called before netns
setup is done, oopsing in net_generic().
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/ip6_tunnel.c')
-rw-r--r-- | net/ipv6/ip6_tunnel.c | 28 |
1 files changed, 15 insertions, 13 deletions
diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c index fbd786981aa9..9b02492d8706 100644 --- a/net/ipv6/ip6_tunnel.c +++ b/net/ipv6/ip6_tunnel.c | |||
@@ -1461,27 +1461,29 @@ static int __init ip6_tunnel_init(void) | |||
1461 | { | 1461 | { |
1462 | int err; | 1462 | int err; |
1463 | 1463 | ||
1464 | if (xfrm6_tunnel_register(&ip4ip6_handler, AF_INET)) { | 1464 | err = register_pernet_device(&ip6_tnl_net_ops); |
1465 | if (err < 0) | ||
1466 | goto out_pernet; | ||
1467 | |||
1468 | err = xfrm6_tunnel_register(&ip4ip6_handler, AF_INET); | ||
1469 | if (err < 0) { | ||
1465 | printk(KERN_ERR "ip6_tunnel init: can't register ip4ip6\n"); | 1470 | printk(KERN_ERR "ip6_tunnel init: can't register ip4ip6\n"); |
1466 | err = -EAGAIN; | 1471 | goto out_ip4ip6; |
1467 | goto out; | ||
1468 | } | 1472 | } |
1469 | 1473 | ||
1470 | if (xfrm6_tunnel_register(&ip6ip6_handler, AF_INET6)) { | 1474 | err = xfrm6_tunnel_register(&ip6ip6_handler, AF_INET6); |
1475 | if (err < 0) { | ||
1471 | printk(KERN_ERR "ip6_tunnel init: can't register ip6ip6\n"); | 1476 | printk(KERN_ERR "ip6_tunnel init: can't register ip6ip6\n"); |
1472 | err = -EAGAIN; | 1477 | goto out_ip6ip6; |
1473 | goto unreg_ip4ip6; | ||
1474 | } | 1478 | } |
1475 | 1479 | ||
1476 | err = register_pernet_device(&ip6_tnl_net_ops); | ||
1477 | if (err < 0) | ||
1478 | goto err_pernet; | ||
1479 | return 0; | 1480 | return 0; |
1480 | err_pernet: | 1481 | |
1481 | xfrm6_tunnel_deregister(&ip6ip6_handler, AF_INET6); | 1482 | out_ip6ip6: |
1482 | unreg_ip4ip6: | ||
1483 | xfrm6_tunnel_deregister(&ip4ip6_handler, AF_INET); | 1483 | xfrm6_tunnel_deregister(&ip4ip6_handler, AF_INET); |
1484 | out: | 1484 | out_ip4ip6: |
1485 | unregister_pernet_device(&ip6_tnl_net_ops); | ||
1486 | out_pernet: | ||
1485 | return err; | 1487 | return err; |
1486 | } | 1488 | } |
1487 | 1489 | ||