diff options
author | Patrick McHardy <kaber@trash.net> | 2006-01-07 02:02:34 -0500 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2006-01-07 15:57:29 -0500 |
commit | 951dbc8ac714b04c36296b8b5c36c8e036ce433f (patch) | |
tree | 7f3599987f6b6db765f66c65d5c1cefe1457ea6a /net/ipv6/ip6_input.c | |
parent | 16a6677fdf1d1194f688f8291b06fbaff248c353 (diff) |
[IPV6]: Move nextheader offset to the IP6CB
Move nextheader offset to the IP6CB to make it possible to pass a
packet to ip6_input_finish multiple times and have it skip already
parsed headers. As a nice side effect this gets rid of the manual
hopopts skipping in ip6_input_finish.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/ip6_input.c')
-rw-r--r-- | net/ipv6/ip6_input.c | 21 |
1 files changed, 6 insertions, 15 deletions
diff --git a/net/ipv6/ip6_input.c b/net/ipv6/ip6_input.c index a6026d2787d2..13d724150f33 100644 --- a/net/ipv6/ip6_input.c +++ b/net/ipv6/ip6_input.c | |||
@@ -97,6 +97,9 @@ int ipv6_rcv(struct sk_buff *skb, struct net_device *dev, struct packet_type *pt | |||
97 | if (hdr->version != 6) | 97 | if (hdr->version != 6) |
98 | goto err; | 98 | goto err; |
99 | 99 | ||
100 | skb->h.raw = (u8 *)(hdr + 1); | ||
101 | IP6CB(skb)->nhoff = offsetof(struct ipv6hdr, nexthdr); | ||
102 | |||
100 | pkt_len = ntohs(hdr->payload_len); | 103 | pkt_len = ntohs(hdr->payload_len); |
101 | 104 | ||
102 | /* pkt_len may be zero if Jumbo payload option is present */ | 105 | /* pkt_len may be zero if Jumbo payload option is present */ |
@@ -111,8 +114,7 @@ int ipv6_rcv(struct sk_buff *skb, struct net_device *dev, struct packet_type *pt | |||
111 | } | 114 | } |
112 | 115 | ||
113 | if (hdr->nexthdr == NEXTHDR_HOP) { | 116 | if (hdr->nexthdr == NEXTHDR_HOP) { |
114 | skb->h.raw = (u8*)(hdr+1); | 117 | if (ipv6_parse_hopopts(skb, IP6CB(skb)->nhoff) < 0) { |
115 | if (ipv6_parse_hopopts(skb, offsetof(struct ipv6hdr, nexthdr)) < 0) { | ||
116 | IP6_INC_STATS_BH(IPSTATS_MIB_INHDRERRORS); | 118 | IP6_INC_STATS_BH(IPSTATS_MIB_INHDRERRORS); |
117 | return 0; | 119 | return 0; |
118 | } | 120 | } |
@@ -143,26 +145,15 @@ static inline int ip6_input_finish(struct sk_buff *skb) | |||
143 | int nexthdr; | 145 | int nexthdr; |
144 | u8 hash; | 146 | u8 hash; |
145 | 147 | ||
146 | skb->h.raw = skb->nh.raw + sizeof(struct ipv6hdr); | ||
147 | |||
148 | /* | 148 | /* |
149 | * Parse extension headers | 149 | * Parse extension headers |
150 | */ | 150 | */ |
151 | 151 | ||
152 | nexthdr = skb->nh.ipv6h->nexthdr; | ||
153 | nhoff = offsetof(struct ipv6hdr, nexthdr); | ||
154 | |||
155 | /* Skip hop-by-hop options, they are already parsed. */ | ||
156 | if (nexthdr == NEXTHDR_HOP) { | ||
157 | nhoff = sizeof(struct ipv6hdr); | ||
158 | nexthdr = skb->h.raw[0]; | ||
159 | skb->h.raw += (skb->h.raw[1]+1)<<3; | ||
160 | } | ||
161 | |||
162 | rcu_read_lock(); | 152 | rcu_read_lock(); |
163 | resubmit: | 153 | resubmit: |
164 | if (!pskb_pull(skb, skb->h.raw - skb->data)) | 154 | if (!pskb_pull(skb, skb->h.raw - skb->data)) |
165 | goto discard; | 155 | goto discard; |
156 | nhoff = IP6CB(skb)->nhoff; | ||
166 | nexthdr = skb->nh.raw[nhoff]; | 157 | nexthdr = skb->nh.raw[nhoff]; |
167 | 158 | ||
168 | raw_sk = sk_head(&raw_v6_htable[nexthdr & (MAX_INET_PROTOS - 1)]); | 159 | raw_sk = sk_head(&raw_v6_htable[nexthdr & (MAX_INET_PROTOS - 1)]); |
@@ -194,7 +185,7 @@ resubmit: | |||
194 | !xfrm6_policy_check(NULL, XFRM_POLICY_IN, skb)) | 185 | !xfrm6_policy_check(NULL, XFRM_POLICY_IN, skb)) |
195 | goto discard; | 186 | goto discard; |
196 | 187 | ||
197 | ret = ipprot->handler(&skb, &nhoff); | 188 | ret = ipprot->handler(&skb); |
198 | if (ret > 0) | 189 | if (ret > 0) |
199 | goto resubmit; | 190 | goto resubmit; |
200 | else if (ret == 0) | 191 | else if (ret == 0) |