diff options
author | Hannes Frederic Sowa <hannes@stressinduktion.org> | 2013-10-19 15:48:57 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-10-19 19:45:35 -0400 |
commit | 1bbdceef1e535add893bf71d7b7ab102e4eb69eb (patch) | |
tree | e2eed21c778d0a6458f8350ce5f6fbfc6c58810e /net/ipv6/inet6_hashtables.c | |
parent | b23a002fc6f0c19846ee0382f019429af54a27e9 (diff) |
inet: convert inet_ehash_secret and ipv6_hash_secret to net_get_random_once
Initialize the ehash and ipv6_hash_secrets with net_get_random_once.
Each compilation unit gets its own secret now:
ipv4/inet_hashtables.o
ipv4/udp.o
ipv6/inet6_hashtables.o
ipv6/udp.o
rds/connection.o
The functions still get inlined into the hashing functions. In the fast
path we have at most two (needed in ipv6) if (unlikely(...)).
Cc: Eric Dumazet <edumazet@google.com>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/inet6_hashtables.c')
-rw-r--r-- | net/ipv6/inet6_hashtables.c | 15 |
1 files changed, 12 insertions, 3 deletions
diff --git a/net/ipv6/inet6_hashtables.c b/net/ipv6/inet6_hashtables.c index fa7dd3856c55..262e13c02ec2 100644 --- a/net/ipv6/inet6_hashtables.c +++ b/net/ipv6/inet6_hashtables.c | |||
@@ -29,10 +29,19 @@ static unsigned int inet6_ehashfn(struct net *net, | |||
29 | const struct in6_addr *faddr, | 29 | const struct in6_addr *faddr, |
30 | const __be16 fport) | 30 | const __be16 fport) |
31 | { | 31 | { |
32 | const u32 lhash = (__force u32)laddr->s6_addr32[3]; | 32 | static u32 inet6_ehash_secret __read_mostly; |
33 | const u32 fhash = __ipv6_addr_jhash(faddr, ipv6_hash_secret); | 33 | static u32 ipv6_hash_secret __read_mostly; |
34 | |||
35 | u32 lhash, fhash; | ||
36 | |||
37 | net_get_random_once(&inet6_ehash_secret, sizeof(inet6_ehash_secret)); | ||
38 | net_get_random_once(&ipv6_hash_secret, sizeof(ipv6_hash_secret)); | ||
39 | |||
40 | lhash = (__force u32)laddr->s6_addr32[3]; | ||
41 | fhash = __ipv6_addr_jhash(faddr, ipv6_hash_secret); | ||
42 | |||
34 | return __inet6_ehashfn(lhash, lport, fhash, fport, | 43 | return __inet6_ehashfn(lhash, lport, fhash, fport, |
35 | inet_ehash_secret + net_hash_mix(net)); | 44 | inet6_ehash_secret + net_hash_mix(net)); |
36 | } | 45 | } |
37 | 46 | ||
38 | static int inet6_sk_ehashfn(const struct sock *sk) | 47 | static int inet6_sk_ehashfn(const struct sock *sk) |