diff options
author | Herbert Xu <herbert@gondor.apana.org.au> | 2007-12-16 18:55:02 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 17:53:51 -0500 |
commit | 668dc8af3150f837f7f0461001bbbc0ce25d7bdf (patch) | |
tree | 9ba3534a190bb69b3aebf24aaa4340685fe16539 /net/ipv6/ah6.c | |
parent | b2aa5e9d43a38dcdfa0878ed750cf32f98460278 (diff) |
[IPSEC]: Move integrity stat collection into xfrm_input
Similar to the moving out of the replay processing on the output, this
patch moves the integrity stat collectin from x->type->input into
xfrm_input.
This would eventually allow transforms such as AH/ESP to be lockless.
The error value EBADMSG (currently unused in the crypto layer) is used
to indicate a failed integrity check. In future this error can be
directly returned by the crypto layer once we switch to aead
algorithms.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/ah6.c')
-rw-r--r-- | net/ipv6/ah6.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/ipv6/ah6.c b/net/ipv6/ah6.c index 4eaf55072b1b..d4b59ecb0b57 100644 --- a/net/ipv6/ah6.c +++ b/net/ipv6/ah6.c | |||
@@ -379,10 +379,9 @@ static int ah6_input(struct xfrm_state *x, struct sk_buff *skb) | |||
379 | err = ah_mac_digest(ahp, skb, ah->auth_data); | 379 | err = ah_mac_digest(ahp, skb, ah->auth_data); |
380 | if (err) | 380 | if (err) |
381 | goto free_out; | 381 | goto free_out; |
382 | err = -EINVAL; | ||
383 | if (memcmp(ahp->work_icv, auth_data, ahp->icv_trunc_len)) { | 382 | if (memcmp(ahp->work_icv, auth_data, ahp->icv_trunc_len)) { |
384 | LIMIT_NETDEBUG(KERN_WARNING "ipsec ah authentication error\n"); | 383 | LIMIT_NETDEBUG(KERN_WARNING "ipsec ah authentication error\n"); |
385 | x->stats.integrity_failed++; | 384 | err = -EBADMSG; |
386 | goto free_out; | 385 | goto free_out; |
387 | } | 386 | } |
388 | } | 387 | } |