netfilter: Use IS_ERR_OR_NULL().

Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

2 files changed, 10 insertions, 10 deletions

diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c
index 3ea4127404d6..7dc6a9743592 100644
--- a/net/ipv4/netfilter/arp_tables.c
+++ b/net/ipv4/netfilter/arp_tables.c
@@ -901,7 +901,7 @@ static int get_info(struct net *net, void __user *user,
 #endif
         t = try_then_request_module(xt_find_table_lock(net, NFPROTO_ARP, name),
                                     "arptable_%s", name);
-        if (t && !IS_ERR(t)) {
+        if (!IS_ERR_OR_NULL(t)) {
                 struct arpt_getinfo info;
                 const struct xt_table_info *private = t->private;
 #ifdef CONFIG_COMPAT
@@ -958,7 +958,7 @@ static int get_entries(struct net *net, struct arpt_get_entries __user *uptr,
         }
 
         t = xt_find_table_lock(net, NFPROTO_ARP, get.name);
-        if (t && !IS_ERR(t)) {
+        if (!IS_ERR_OR_NULL(t)) {
                 const struct xt_table_info *private = t->private;
 
                 duprintf("t->private->number = %u\n",
@@ -1001,7 +1001,7 @@ static int __do_replace(struct net *net, const char *name,
 
         t = try_then_request_module(xt_find_table_lock(net, NFPROTO_ARP, name),
                                     "arptable_%s", name);
-        if (!t || IS_ERR(t)) {
+        if (IS_ERR_OR_NULL(t)) {
                 ret = t ? PTR_ERR(t) : -ENOENT;
                 goto free_newinfo_counters_untrans;
         }
@@ -1158,7 +1158,7 @@ static int do_add_counters(struct net *net, const void __user *user,
         }
 
         t = xt_find_table_lock(net, NFPROTO_ARP, name);
-        if (!t || IS_ERR(t)) {
+        if (IS_ERR_OR_NULL(t)) {
                 ret = t ? PTR_ERR(t) : -ENOENT;
                 goto free;
         }
@@ -1646,7 +1646,7 @@ static int compat_get_entries(struct net *net,
 
         xt_compat_lock(NFPROTO_ARP);
         t = xt_find_table_lock(net, NFPROTO_ARP, get.name);
-        if (t && !IS_ERR(t)) {
+        if (!IS_ERR_OR_NULL(t)) {
                 const struct xt_table_info *private = t->private;
                 struct xt_table_info info;
 
diff --git a/net/ipv4/netfilter/ip_tables.c b/net/ipv4/netfilter/ip_tables.c
index 17c5e06da662..3efcf87400c3 100644
--- a/net/ipv4/netfilter/ip_tables.c
+++ b/net/ipv4/netfilter/ip_tables.c
@@ -1090,7 +1090,7 @@ static int get_info(struct net *net, void __user *user,
 #endif
         t = try_then_request_module(xt_find_table_lock(net, AF_INET, name),
                                     "iptable_%s", name);
-        if (t && !IS_ERR(t)) {
+        if (!IS_ERR_OR_NULL(t)) {
                 struct ipt_getinfo info;
                 const struct xt_table_info *private = t->private;
 #ifdef CONFIG_COMPAT
@@ -1149,7 +1149,7 @@ get_entries(struct net *net, struct ipt_get_entries __user *uptr,
         }
 
         t = xt_find_table_lock(net, AF_INET, get.name);
-        if (t && !IS_ERR(t)) {
+        if (!IS_ERR_OR_NULL(t)) {
                 const struct xt_table_info *private = t->private;
                 duprintf("t->private->number = %u\n", private->number);
                 if (get.size == private->size)
@@ -1189,7 +1189,7 @@ __do_replace(struct net *net, const char *name, unsigned int valid_hooks,
 
         t = try_then_request_module(xt_find_table_lock(net, AF_INET, name),
                                     "iptable_%s", name);
-        if (!t || IS_ERR(t)) {
+        if (IS_ERR_OR_NULL(t)) {
                 ret = t ? PTR_ERR(t) : -ENOENT;
                 goto free_newinfo_counters_untrans;
         }
@@ -1347,7 +1347,7 @@ do_add_counters(struct net *net, const void __user *user,
         }
 
         t = xt_find_table_lock(net, AF_INET, name);
-        if (!t || IS_ERR(t)) {
+        if (IS_ERR_OR_NULL(t)) {
                 ret = t ? PTR_ERR(t) : -ENOENT;
                 goto free;
         }
@@ -1931,7 +1931,7 @@ compat_get_entries(struct net *net, struct compat_ipt_get_entries __user *uptr,
 
         xt_compat_lock(AF_INET);
         t = xt_find_table_lock(net, AF_INET, get.name);
-        if (t && !IS_ERR(t)) {
+        if (!IS_ERR_OR_NULL(t)) {
                 const struct xt_table_info *private = t->private;
                 struct xt_table_info info;
                 duprintf("t->private->number = %u\n", private->number);