mib: put udp statistics on struct net

Similar to... ouch, I repeat myself.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

3 files changed, 7 insertions, 9 deletions

diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
index 776ed3199b52..1f418164ebf2 100644
--- a/net/ipv4/af_inet.c
+++ b/net/ipv4/af_inet.c
@@ -1349,10 +1349,15 @@ static __net_init int ipv4_mib_init_net(struct net *net)
         if (snmp_mib_init((void **)net->mib.net_statistics,
                           sizeof(struct linux_mib)) < 0)
                 goto err_net_mib;
+        if (snmp_mib_init((void **)net->mib.udp_statistics,
+                          sizeof(struct udp_mib)) < 0)
+                goto err_udp_mib;
 
         tcp_mib_init(net);
         return 0;
 
+err_udp_mib:
+        snmp_mib_free((void **)net->mib.net_statistics);
 err_net_mib:
         snmp_mib_free((void **)net->mib.ip_statistics);
 err_ip_mib:
@@ -1363,6 +1368,7 @@ err_tcp_mib:
 
 static __net_exit void ipv4_mib_exit_net(struct net *net)
 {
+        snmp_mib_free((void **)net->mib.udp_statistics);
         snmp_mib_free((void **)net->mib.net_statistics);
         snmp_mib_free((void **)net->mib.ip_statistics);
         snmp_mib_free((void **)net->mib.tcp_statistics);
@@ -1381,9 +1387,6 @@ static int __init init_ipv4_mibs(void)
         if (snmp_mib_init((void **)icmpmsg_statistics,
                           sizeof(struct icmpmsg_mib)) < 0)
                 goto err_icmpmsg_mib;
-        if (snmp_mib_init((void **)udp_statistics,
-                          sizeof(struct udp_mib)) < 0)
-                goto err_udp_mib;
         if (snmp_mib_init((void **)udplite_statistics,
                           sizeof(struct udp_mib)) < 0)
                 goto err_udplite_mib;
@@ -1396,8 +1399,6 @@ static int __init init_ipv4_mibs(void)
 err_net:
         snmp_mib_free((void **)udplite_statistics);
 err_udplite_mib:
-        snmp_mib_free((void **)udp_statistics);
-err_udp_mib:
         snmp_mib_free((void **)icmpmsg_statistics);
 err_icmpmsg_mib:
         snmp_mib_free((void **)icmp_statistics);
diff --git a/net/ipv4/proc.c b/net/ipv4/proc.c
index ef38b1dccfda..869085c8e43f 100644
--- a/net/ipv4/proc.c
+++ b/net/ipv4/proc.c
@@ -374,7 +374,7 @@ static int snmp_seq_show(struct seq_file *seq, void *v)
         seq_puts(seq, "\nUdp:");
         for (i = 0; snmp4_udp_list[i].name != NULL; i++)
                 seq_printf(seq, " %lu",
-                           snmp_fold_field((void **)udp_statistics,
+                           snmp_fold_field((void **)init_net.mib.udp_statistics,
                                            snmp4_udp_list[i].entry));
 
         /* the UDP and UDP-Lite MIBs are the same */
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index 1560d11ba6ef..a751770947a3 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -108,9 +108,6 @@
  *      Snmp MIB for the UDP layer
  */
 
-DEFINE_SNMP_STAT(struct udp_mib, udp_statistics) __read_mostly;
-EXPORT_SYMBOL(udp_statistics);
-
 DEFINE_SNMP_STAT(struct udp_mib, udp_stats_in6) __read_mostly;
 EXPORT_SYMBOL(udp_stats_in6);