diff options
author | Pavel Emelyanov <xemul@openvz.org> | 2007-11-20 01:52:41 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 17:54:35 -0500 |
commit | 85b606800be20ceeca36bd8594c1eb228d2fb2f4 (patch) | |
tree | 4a9f09e3b12583c7c17858b61b77aa26eccd3547 /net/ipv4 | |
parent | 52427c9d11477d5a2633d81050f52523decf9eff (diff) |
[IPVS]: Relax the module get/put in ip_vs_app.c
Both try_module_get/module_put already handle the module == NULL
case, so no need in manual checking.
This patch fits both net-2.6 and net-2.6.25.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Acked-by: Simon Horman <horms@verge.net.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
-rw-r--r-- | net/ipv4/ipvs/ip_vs_app.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/net/ipv4/ipvs/ip_vs_app.c b/net/ipv4/ipvs/ip_vs_app.c index 664cb8e97c1c..535abe0c45e7 100644 --- a/net/ipv4/ipvs/ip_vs_app.c +++ b/net/ipv4/ipvs/ip_vs_app.c | |||
@@ -51,18 +51,13 @@ static DEFINE_MUTEX(__ip_vs_app_mutex); | |||
51 | */ | 51 | */ |
52 | static inline int ip_vs_app_get(struct ip_vs_app *app) | 52 | static inline int ip_vs_app_get(struct ip_vs_app *app) |
53 | { | 53 | { |
54 | /* test and get the module atomically */ | 54 | return try_module_get(app->module); |
55 | if (app->module) | ||
56 | return try_module_get(app->module); | ||
57 | else | ||
58 | return 1; | ||
59 | } | 55 | } |
60 | 56 | ||
61 | 57 | ||
62 | static inline void ip_vs_app_put(struct ip_vs_app *app) | 58 | static inline void ip_vs_app_put(struct ip_vs_app *app) |
63 | { | 59 | { |
64 | if (app->module) | 60 | module_put(app->module); |
65 | module_put(app->module); | ||
66 | } | 61 | } |
67 | 62 | ||
68 | 63 | ||