diff options
author | Patrick McHardy <kaber@trash.net> | 2007-12-05 04:25:03 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 17:56:11 -0500 |
commit | 0ac41e81462de20f87242caac2b9084c202c33b7 (patch) | |
tree | 4978450cfe485614fc2c0ef962ebbfbc9dff5cf9 /net/ipv4 | |
parent | c01cd429fc118c5db92475c5f08b307718aa4efc (diff) |
[NETFILTER]: {nf_netlink,ip,ip6}_queue: use list_for_each_entry
Use list_add_tail/list_for_each_entry instead of list_add and
list_for_each_prev as a preparation for switching to RCU.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
-rw-r--r-- | net/ipv4/netfilter/ip_queue.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/net/ipv4/netfilter/ip_queue.c b/net/ipv4/netfilter/ip_queue.c index 2966fbddce8b..9e72246ede25 100644 --- a/net/ipv4/netfilter/ip_queue.c +++ b/net/ipv4/netfilter/ip_queue.c | |||
@@ -73,7 +73,7 @@ ipq_issue_verdict(struct ipq_queue_entry *entry, int verdict) | |||
73 | static inline void | 73 | static inline void |
74 | __ipq_enqueue_entry(struct ipq_queue_entry *entry) | 74 | __ipq_enqueue_entry(struct ipq_queue_entry *entry) |
75 | { | 75 | { |
76 | list_add(&entry->list, &queue_list); | 76 | list_add_tail(&entry->list, &queue_list); |
77 | queue_total++; | 77 | queue_total++; |
78 | } | 78 | } |
79 | 79 | ||
@@ -84,11 +84,9 @@ __ipq_enqueue_entry(struct ipq_queue_entry *entry) | |||
84 | static inline struct ipq_queue_entry * | 84 | static inline struct ipq_queue_entry * |
85 | __ipq_find_entry(ipq_cmpfn cmpfn, unsigned long data) | 85 | __ipq_find_entry(ipq_cmpfn cmpfn, unsigned long data) |
86 | { | 86 | { |
87 | struct list_head *p; | 87 | struct ipq_queue_entry *entry; |
88 | |||
89 | list_for_each_prev(p, &queue_list) { | ||
90 | struct ipq_queue_entry *entry = (struct ipq_queue_entry *)p; | ||
91 | 88 | ||
89 | list_for_each_entry(entry, &queue_list, list) { | ||
92 | if (!cmpfn || cmpfn(entry, data)) | 90 | if (!cmpfn || cmpfn(entry, data)) |
93 | return entry; | 91 | return entry; |
94 | } | 92 | } |