diff options
author | Arnaldo Carvalho de Melo <acme@ghostprotocols.net> | 2007-03-31 10:55:19 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-04-26 01:28:29 -0400 |
commit | 27d7ff46a3498d3debc6ba68fb8014c702b81170 (patch) | |
tree | b5a0c617cf8339524d3b1f1633e08eae7b94cf86 /net/ipv4 | |
parent | 3dbad80ac7632f243b824d469301abb97ec634a1 (diff) |
[SK_BUFF]: Introduce skb_copy_to_linear_data{_offset}
To clearly state the intent of copying to linear sk_buffs, _offset being a
overly long variant but interesting for the sake of saving some bytes.
Signed-off-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Diffstat (limited to 'net/ipv4')
-rw-r--r-- | net/ipv4/ipcomp.c | 2 | ||||
-rw-r--r-- | net/ipv4/ipmr.c | 2 | ||||
-rw-r--r-- | net/ipv4/ipvs/ip_vs_app.c | 2 | ||||
-rw-r--r-- | net/ipv4/netfilter/ip_queue.c | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/net/ipv4/ipcomp.c b/net/ipv4/ipcomp.c index ba348b1e5f84..ab86137c71d2 100644 --- a/net/ipv4/ipcomp.c +++ b/net/ipv4/ipcomp.c | |||
@@ -66,7 +66,7 @@ static int ipcomp_decompress(struct xfrm_state *x, struct sk_buff *skb) | |||
66 | 66 | ||
67 | skb->truesize += dlen - plen; | 67 | skb->truesize += dlen - plen; |
68 | __skb_put(skb, dlen - plen); | 68 | __skb_put(skb, dlen - plen); |
69 | memcpy(skb->data, scratch, dlen); | 69 | skb_copy_to_linear_data(skb, scratch, dlen); |
70 | out: | 70 | out: |
71 | put_cpu(); | 71 | put_cpu(); |
72 | return err; | 72 | return err; |
diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c index 48027df5a90b..0ebae413ae87 100644 --- a/net/ipv4/ipmr.c +++ b/net/ipv4/ipmr.c | |||
@@ -584,7 +584,7 @@ static int ipmr_cache_report(struct sk_buff *pkt, vifi_t vifi, int assert) | |||
584 | 584 | ||
585 | skb->network_header = skb->tail; | 585 | skb->network_header = skb->tail; |
586 | skb_put(skb, ihl); | 586 | skb_put(skb, ihl); |
587 | memcpy(skb->data,pkt->data,ihl); | 587 | skb_copy_to_linear_data(skb, pkt->data, ihl); |
588 | ip_hdr(skb)->protocol = 0; /* Flag to the kernel this is a route add */ | 588 | ip_hdr(skb)->protocol = 0; /* Flag to the kernel this is a route add */ |
589 | msg = (struct igmpmsg *)skb_network_header(skb); | 589 | msg = (struct igmpmsg *)skb_network_header(skb); |
590 | msg->im_vif = vifi; | 590 | msg->im_vif = vifi; |
diff --git a/net/ipv4/ipvs/ip_vs_app.c b/net/ipv4/ipvs/ip_vs_app.c index c8a822c0aa75..15ad5dd2d984 100644 --- a/net/ipv4/ipvs/ip_vs_app.c +++ b/net/ipv4/ipvs/ip_vs_app.c | |||
@@ -602,7 +602,7 @@ int ip_vs_skb_replace(struct sk_buff *skb, gfp_t pri, | |||
602 | skb_put(skb, diff); | 602 | skb_put(skb, diff); |
603 | memmove(skb->data + o_offset + n_len, | 603 | memmove(skb->data + o_offset + n_len, |
604 | skb->data + o_offset + o_len, o_left); | 604 | skb->data + o_offset + o_len, o_left); |
605 | memcpy(skb->data + o_offset, n_buf, n_len); | 605 | skb_copy_to_linear_data_offset(skb, o_offset, n_buf, n_len); |
606 | } | 606 | } |
607 | 607 | ||
608 | /* must update the iph total length here */ | 608 | /* must update the iph total length here */ |
diff --git a/net/ipv4/netfilter/ip_queue.c b/net/ipv4/netfilter/ip_queue.c index cd8fec05f9bc..0d72693869e6 100644 --- a/net/ipv4/netfilter/ip_queue.c +++ b/net/ipv4/netfilter/ip_queue.c | |||
@@ -368,7 +368,7 @@ ipq_mangle_ipv4(ipq_verdict_msg_t *v, struct ipq_queue_entry *e) | |||
368 | } | 368 | } |
369 | if (!skb_make_writable(&e->skb, v->data_len)) | 369 | if (!skb_make_writable(&e->skb, v->data_len)) |
370 | return -ENOMEM; | 370 | return -ENOMEM; |
371 | memcpy(e->skb->data, v->payload, v->data_len); | 371 | skb_copy_to_linear_data(e->skb, v->payload, v->data_len); |
372 | e->skb->ip_summed = CHECKSUM_NONE; | 372 | e->skb->ip_summed = CHECKSUM_NONE; |
373 | 373 | ||
374 | return 0; | 374 | return 0; |