diff options
author | Eric Dumazet <eric.dumazet@gmail.com> | 2010-09-22 16:43:57 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-09-23 17:33:39 -0400 |
commit | a02cec2155fbea457eca8881870fd2de1a4c4c76 (patch) | |
tree | cfbfc4b32bfe10f9cd803d46c31607d13f1858f5 /net/ipv4 | |
parent | 6a08d194ee40806e0ccd5f36ed768e64cbfc979f (diff) |
net: return operator cleanup
Change "return (EXPR);" to "return EXPR;"
return is not a function, parentheses are not required.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
-rw-r--r-- | net/ipv4/arp.c | 2 | ||||
-rw-r--r-- | net/ipv4/datagram.c | 2 | ||||
-rw-r--r-- | net/ipv4/inet_diag.c | 2 | ||||
-rw-r--r-- | net/ipv4/ip_fragment.c | 4 | ||||
-rw-r--r-- | net/ipv4/ip_gre.c | 2 | ||||
-rw-r--r-- | net/ipv4/netfilter/arp_tables.c | 2 | ||||
-rw-r--r-- | net/ipv4/route.c | 2 | ||||
-rw-r--r-- | net/ipv4/tcp_input.c | 10 | ||||
-rw-r--r-- | net/ipv4/tcp_minisocks.c | 2 | ||||
-rw-r--r-- | net/ipv4/tcp_output.c | 8 | ||||
-rw-r--r-- | net/ipv4/tcp_westwood.c | 2 |
11 files changed, 19 insertions, 19 deletions
diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c index dcfe7e961c10..4083c186fd30 100644 --- a/net/ipv4/arp.c +++ b/net/ipv4/arp.c | |||
@@ -567,7 +567,7 @@ static inline int arp_fwd_proxy(struct in_device *in_dev, | |||
567 | if (out_dev) | 567 | if (out_dev) |
568 | omi = IN_DEV_MEDIUM_ID(out_dev); | 568 | omi = IN_DEV_MEDIUM_ID(out_dev); |
569 | 569 | ||
570 | return (omi != imi && omi != -1); | 570 | return omi != imi && omi != -1; |
571 | } | 571 | } |
572 | 572 | ||
573 | /* | 573 | /* |
diff --git a/net/ipv4/datagram.c b/net/ipv4/datagram.c index 721a8a37b45c..174be6caa5c8 100644 --- a/net/ipv4/datagram.c +++ b/net/ipv4/datagram.c | |||
@@ -73,6 +73,6 @@ int ip4_datagram_connect(struct sock *sk, struct sockaddr *uaddr, int addr_len) | |||
73 | inet->inet_id = jiffies; | 73 | inet->inet_id = jiffies; |
74 | 74 | ||
75 | sk_dst_set(sk, &rt->dst); | 75 | sk_dst_set(sk, &rt->dst); |
76 | return(0); | 76 | return 0; |
77 | } | 77 | } |
78 | EXPORT_SYMBOL(ip4_datagram_connect); | 78 | EXPORT_SYMBOL(ip4_datagram_connect); |
diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c index e5fa2ddce320..ba8042665849 100644 --- a/net/ipv4/inet_diag.c +++ b/net/ipv4/inet_diag.c | |||
@@ -425,7 +425,7 @@ static int inet_diag_bc_run(const void *bc, int len, | |||
425 | bc += op->no; | 425 | bc += op->no; |
426 | } | 426 | } |
427 | } | 427 | } |
428 | return (len == 0); | 428 | return len == 0; |
429 | } | 429 | } |
430 | 430 | ||
431 | static int valid_cc(const void *bc, int len, int cc) | 431 | static int valid_cc(const void *bc, int len, int cc) |
diff --git a/net/ipv4/ip_fragment.c b/net/ipv4/ip_fragment.c index f4dc879e258e..168440834ade 100644 --- a/net/ipv4/ip_fragment.c +++ b/net/ipv4/ip_fragment.c | |||
@@ -116,11 +116,11 @@ static int ip4_frag_match(struct inet_frag_queue *q, void *a) | |||
116 | struct ip4_create_arg *arg = a; | 116 | struct ip4_create_arg *arg = a; |
117 | 117 | ||
118 | qp = container_of(q, struct ipq, q); | 118 | qp = container_of(q, struct ipq, q); |
119 | return (qp->id == arg->iph->id && | 119 | return qp->id == arg->iph->id && |
120 | qp->saddr == arg->iph->saddr && | 120 | qp->saddr == arg->iph->saddr && |
121 | qp->daddr == arg->iph->daddr && | 121 | qp->daddr == arg->iph->daddr && |
122 | qp->protocol == arg->iph->protocol && | 122 | qp->protocol == arg->iph->protocol && |
123 | qp->user == arg->user); | 123 | qp->user == arg->user; |
124 | } | 124 | } |
125 | 125 | ||
126 | /* Memory Tracking Functions. */ | 126 | /* Memory Tracking Functions. */ |
diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c index 714b6a80361d..0967d02fefd8 100644 --- a/net/ipv4/ip_gre.c +++ b/net/ipv4/ip_gre.c | |||
@@ -659,7 +659,7 @@ drop: | |||
659 | rcu_read_unlock(); | 659 | rcu_read_unlock(); |
660 | drop_nolock: | 660 | drop_nolock: |
661 | kfree_skb(skb); | 661 | kfree_skb(skb); |
662 | return(0); | 662 | return 0; |
663 | } | 663 | } |
664 | 664 | ||
665 | static netdev_tx_t ipgre_tunnel_xmit(struct sk_buff *skb, struct net_device *dev) | 665 | static netdev_tx_t ipgre_tunnel_xmit(struct sk_buff *skb, struct net_device *dev) |
diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c index e8f4f9a57f12..8b642f152468 100644 --- a/net/ipv4/netfilter/arp_tables.c +++ b/net/ipv4/netfilter/arp_tables.c | |||
@@ -72,7 +72,7 @@ static inline int arp_devaddr_compare(const struct arpt_devaddr_info *ap, | |||
72 | for (i = 0; i < len; i++) | 72 | for (i = 0; i < len; i++) |
73 | ret |= (hdr_addr[i] ^ ap->addr[i]) & ap->mask[i]; | 73 | ret |= (hdr_addr[i] ^ ap->addr[i]) & ap->mask[i]; |
74 | 74 | ||
75 | return (ret != 0); | 75 | return ret != 0; |
76 | } | 76 | } |
77 | 77 | ||
78 | /* | 78 | /* |
diff --git a/net/ipv4/route.c b/net/ipv4/route.c index e24d48dd99d3..ae1d4a41f1c6 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c | |||
@@ -2791,7 +2791,7 @@ static int ipv4_dst_blackhole(struct net *net, struct rtable **rp, struct flowi | |||
2791 | 2791 | ||
2792 | dst_release(&(*rp)->dst); | 2792 | dst_release(&(*rp)->dst); |
2793 | *rp = rt; | 2793 | *rp = rt; |
2794 | return (rt ? 0 : -ENOMEM); | 2794 | return rt ? 0 : -ENOMEM; |
2795 | } | 2795 | } |
2796 | 2796 | ||
2797 | int ip_route_output_flow(struct net *net, struct rtable **rp, struct flowi *flp, | 2797 | int ip_route_output_flow(struct net *net, struct rtable **rp, struct flowi *flp, |
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 1bc87a05c734..51966b3f9719 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c | |||
@@ -2301,7 +2301,7 @@ static inline int tcp_dupack_heuristics(struct tcp_sock *tp) | |||
2301 | 2301 | ||
2302 | static inline int tcp_skb_timedout(struct sock *sk, struct sk_buff *skb) | 2302 | static inline int tcp_skb_timedout(struct sock *sk, struct sk_buff *skb) |
2303 | { | 2303 | { |
2304 | return (tcp_time_stamp - TCP_SKB_CB(skb)->when > inet_csk(sk)->icsk_rto); | 2304 | return tcp_time_stamp - TCP_SKB_CB(skb)->when > inet_csk(sk)->icsk_rto; |
2305 | } | 2305 | } |
2306 | 2306 | ||
2307 | static inline int tcp_head_timedout(struct sock *sk) | 2307 | static inline int tcp_head_timedout(struct sock *sk) |
@@ -3398,8 +3398,8 @@ static void tcp_ack_probe(struct sock *sk) | |||
3398 | 3398 | ||
3399 | static inline int tcp_ack_is_dubious(const struct sock *sk, const int flag) | 3399 | static inline int tcp_ack_is_dubious(const struct sock *sk, const int flag) |
3400 | { | 3400 | { |
3401 | return (!(flag & FLAG_NOT_DUP) || (flag & FLAG_CA_ALERT) || | 3401 | return !(flag & FLAG_NOT_DUP) || (flag & FLAG_CA_ALERT) || |
3402 | inet_csk(sk)->icsk_ca_state != TCP_CA_Open); | 3402 | inet_csk(sk)->icsk_ca_state != TCP_CA_Open; |
3403 | } | 3403 | } |
3404 | 3404 | ||
3405 | static inline int tcp_may_raise_cwnd(const struct sock *sk, const int flag) | 3405 | static inline int tcp_may_raise_cwnd(const struct sock *sk, const int flag) |
@@ -3416,9 +3416,9 @@ static inline int tcp_may_update_window(const struct tcp_sock *tp, | |||
3416 | const u32 ack, const u32 ack_seq, | 3416 | const u32 ack, const u32 ack_seq, |
3417 | const u32 nwin) | 3417 | const u32 nwin) |
3418 | { | 3418 | { |
3419 | return (after(ack, tp->snd_una) || | 3419 | return after(ack, tp->snd_una) || |
3420 | after(ack_seq, tp->snd_wl1) || | 3420 | after(ack_seq, tp->snd_wl1) || |
3421 | (ack_seq == tp->snd_wl1 && nwin > tp->snd_wnd)); | 3421 | (ack_seq == tp->snd_wl1 && nwin > tp->snd_wnd); |
3422 | } | 3422 | } |
3423 | 3423 | ||
3424 | /* Update our send window. | 3424 | /* Update our send window. |
diff --git a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c index f25b56cb85cb..43cf901d7659 100644 --- a/net/ipv4/tcp_minisocks.c +++ b/net/ipv4/tcp_minisocks.c | |||
@@ -55,7 +55,7 @@ static __inline__ int tcp_in_window(u32 seq, u32 end_seq, u32 s_win, u32 e_win) | |||
55 | return 1; | 55 | return 1; |
56 | if (after(end_seq, s_win) && before(seq, e_win)) | 56 | if (after(end_seq, s_win) && before(seq, e_win)) |
57 | return 1; | 57 | return 1; |
58 | return (seq == e_win && seq == end_seq); | 58 | return seq == e_win && seq == end_seq; |
59 | } | 59 | } |
60 | 60 | ||
61 | /* | 61 | /* |
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index ea09d2fd50c7..05b1ecf36763 100644 --- a/net/ipv4/tcp_output.c +++ b/net/ipv4/tcp_output.c | |||
@@ -1370,9 +1370,9 @@ static inline int tcp_nagle_check(const struct tcp_sock *tp, | |||
1370 | const struct sk_buff *skb, | 1370 | const struct sk_buff *skb, |
1371 | unsigned mss_now, int nonagle) | 1371 | unsigned mss_now, int nonagle) |
1372 | { | 1372 | { |
1373 | return (skb->len < mss_now && | 1373 | return skb->len < mss_now && |
1374 | ((nonagle & TCP_NAGLE_CORK) || | 1374 | ((nonagle & TCP_NAGLE_CORK) || |
1375 | (!nonagle && tp->packets_out && tcp_minshall_check(tp)))); | 1375 | (!nonagle && tp->packets_out && tcp_minshall_check(tp))); |
1376 | } | 1376 | } |
1377 | 1377 | ||
1378 | /* Return non-zero if the Nagle test allows this packet to be | 1378 | /* Return non-zero if the Nagle test allows this packet to be |
@@ -1443,10 +1443,10 @@ int tcp_may_send_now(struct sock *sk) | |||
1443 | struct tcp_sock *tp = tcp_sk(sk); | 1443 | struct tcp_sock *tp = tcp_sk(sk); |
1444 | struct sk_buff *skb = tcp_send_head(sk); | 1444 | struct sk_buff *skb = tcp_send_head(sk); |
1445 | 1445 | ||
1446 | return (skb && | 1446 | return skb && |
1447 | tcp_snd_test(sk, skb, tcp_current_mss(sk), | 1447 | tcp_snd_test(sk, skb, tcp_current_mss(sk), |
1448 | (tcp_skb_is_last(sk, skb) ? | 1448 | (tcp_skb_is_last(sk, skb) ? |
1449 | tp->nonagle : TCP_NAGLE_PUSH))); | 1449 | tp->nonagle : TCP_NAGLE_PUSH)); |
1450 | } | 1450 | } |
1451 | 1451 | ||
1452 | /* Trim TSO SKB to LEN bytes, put the remaining data into a new packet | 1452 | /* Trim TSO SKB to LEN bytes, put the remaining data into a new packet |
diff --git a/net/ipv4/tcp_westwood.c b/net/ipv4/tcp_westwood.c index 20151d6a6241..a534dda5456e 100644 --- a/net/ipv4/tcp_westwood.c +++ b/net/ipv4/tcp_westwood.c | |||
@@ -80,7 +80,7 @@ static void tcp_westwood_init(struct sock *sk) | |||
80 | */ | 80 | */ |
81 | static inline u32 westwood_do_filter(u32 a, u32 b) | 81 | static inline u32 westwood_do_filter(u32 a, u32 b) |
82 | { | 82 | { |
83 | return (((7 * a) + b) >> 3); | 83 | return ((7 * a) + b) >> 3; |
84 | } | 84 | } |
85 | 85 | ||
86 | static void westwood_filter(struct westwood *w, u32 delta) | 86 | static void westwood_filter(struct westwood *w, u32 delta) |