diff options
| author | Dan Carpenter <error27@gmail.com> | 2010-05-26 03:38:56 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-05-26 03:38:56 -0400 |
| commit | ed0f160ad674407adb3aba499444f71c83289c63 (patch) | |
| tree | 39cff780164f55d6cda23018431ab553c4477f9e /net/ipv4 | |
| parent | d938a702e5ce8909ea68be97566150507bfea4df (diff) | |
ipmr: off by one in __ipmr_fill_mroute()
This fixes a smatch warning:
net/ipv4/ipmr.c +1917 __ipmr_fill_mroute(12) error: buffer overflow
'(mrt)->vif_table' 32 <= 32
The ipv6 version had the same issue.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
| -rw-r--r-- | net/ipv4/ipmr.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c index 45889103b3e2..856123fe32f9 100644 --- a/net/ipv4/ipmr.c +++ b/net/ipv4/ipmr.c | |||
| @@ -1911,7 +1911,7 @@ static int __ipmr_fill_mroute(struct mr_table *mrt, struct sk_buff *skb, | |||
| 1911 | struct rtattr *mp_head; | 1911 | struct rtattr *mp_head; |
| 1912 | 1912 | ||
| 1913 | /* If cache is unresolved, don't try to parse IIF and OIF */ | 1913 | /* If cache is unresolved, don't try to parse IIF and OIF */ |
| 1914 | if (c->mfc_parent > MAXVIFS) | 1914 | if (c->mfc_parent >= MAXVIFS) |
| 1915 | return -ENOENT; | 1915 | return -ENOENT; |
| 1916 | 1916 | ||
| 1917 | if (VIF_EXISTS(mrt, c->mfc_parent)) | 1917 | if (VIF_EXISTS(mrt, c->mfc_parent)) |