aboutsummaryrefslogtreecommitdiffstats
path: root/net/ipv4/tcp_output.c
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2005-08-09 22:25:21 -0400
committerDavid S. Miller <davem@sunset.davemloft.net>2005-08-29 18:31:14 -0400
commit8728b834b226ffcf2c94a58530090e292af2a7bf (patch)
tree2fd51ff3b7097eb3ffc41ea3a1d8b3ba04715b4c /net/ipv4/tcp_output.c
parent6869c4d8e066e21623c812c448a05f1ed931c9c6 (diff)
[NET]: Kill skb->list
Remove the "list" member of struct sk_buff, as it is entirely redundant. All SKB list removal callers know which list the SKB is on, so storing this in sk_buff does nothing other than taking up some space. Two tricky bits were SCTP, which I took care of, and two ATM drivers which Francois Romieu <romieu@fr.zoreil.com> fixed up. Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Diffstat (limited to 'net/ipv4/tcp_output.c')
-rw-r--r--net/ipv4/tcp_output.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
index dd30dd137b74..a4d1eb9a0926 100644
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -505,7 +505,7 @@ static int tcp_fragment(struct sock *sk, struct sk_buff *skb, u32 len, unsigned
505 505
506 /* Link BUFF into the send queue. */ 506 /* Link BUFF into the send queue. */
507 skb_header_release(buff); 507 skb_header_release(buff);
508 __skb_append(skb, buff); 508 __skb_append(skb, buff, &sk->sk_write_queue);
509 509
510 return 0; 510 return 0;
511} 511}
@@ -893,7 +893,7 @@ static int tso_fragment(struct sock *sk, struct sk_buff *skb, unsigned int len,
893 893
894 /* Link BUFF into the send queue. */ 894 /* Link BUFF into the send queue. */
895 skb_header_release(buff); 895 skb_header_release(buff);
896 __skb_append(skb, buff); 896 __skb_append(skb, buff, &sk->sk_write_queue);
897 897
898 return 0; 898 return 0;
899} 899}
@@ -1238,7 +1238,7 @@ static void tcp_retrans_try_collapse(struct sock *sk, struct sk_buff *skb, int m
1238 tcp_skb_pcount(next_skb) != 1); 1238 tcp_skb_pcount(next_skb) != 1);
1239 1239
1240 /* Ok. We will be able to collapse the packet. */ 1240 /* Ok. We will be able to collapse the packet. */
1241 __skb_unlink(next_skb, next_skb->list); 1241 __skb_unlink(next_skb, &sk->sk_write_queue);
1242 1242
1243 memcpy(skb_put(skb, next_skb_size), next_skb->data, next_skb_size); 1243 memcpy(skb_put(skb, next_skb_size), next_skb->data, next_skb_size);
1244 1244