diff options
author | Peter Zijlstra <peterz@infradead.org> | 2013-11-19 10:13:38 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2014-01-13 11:39:04 -0500 |
commit | 1774e9f3e5c8b38de3b3bc8bd0eacd280f655baf (patch) | |
tree | 97ac0e5f0a9352793c667d7deec15d8e4623ae3e /net/ipv4/tcp.c | |
parent | 8cb75e0c4ec9786b81439761eac1d18d4a931af3 (diff) |
sched, net: Clean up preempt_enable_no_resched() abuse
The only valid use of preempt_enable_no_resched() is if the very next
line is schedule() or if we know preemption cannot actually be enabled
by that statement due to known more preempt_count 'refs'.
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: rjw@rjwysocki.net
Cc: Eliezer Tamir <eliezer.tamir@linux.intel.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: rui.zhang@intel.com
Cc: jacob.jun.pan@linux.intel.com
Cc: Mike Galbraith <bitbucket@online.de>
Cc: hpa@zytor.com
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: lenb@kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/20131119151338.GF3694@twins.programming.kicks-ass.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'net/ipv4/tcp.c')
-rw-r--r-- | net/ipv4/tcp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index c4638e6f0238..82de78603686 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c | |||
@@ -1623,11 +1623,11 @@ int tcp_recvmsg(struct kiocb *iocb, struct sock *sk, struct msghdr *msg, | |||
1623 | (len > sysctl_tcp_dma_copybreak) && !(flags & MSG_PEEK) && | 1623 | (len > sysctl_tcp_dma_copybreak) && !(flags & MSG_PEEK) && |
1624 | !sysctl_tcp_low_latency && | 1624 | !sysctl_tcp_low_latency && |
1625 | net_dma_find_channel()) { | 1625 | net_dma_find_channel()) { |
1626 | preempt_enable_no_resched(); | 1626 | preempt_enable(); |
1627 | tp->ucopy.pinned_list = | 1627 | tp->ucopy.pinned_list = |
1628 | dma_pin_iovec_pages(msg->msg_iov, len); | 1628 | dma_pin_iovec_pages(msg->msg_iov, len); |
1629 | } else { | 1629 | } else { |
1630 | preempt_enable_no_resched(); | 1630 | preempt_enable(); |
1631 | } | 1631 | } |
1632 | } | 1632 | } |
1633 | #endif | 1633 | #endif |