diff options
author | Stephen Hemminger <shemminger@osdl.org> | 2006-08-29 20:48:57 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2006-09-22 18:18:31 -0400 |
commit | 9bcfcaf5e9cc887eb39236e43bdbe4b4b2572229 (patch) | |
tree | 34d6369208bdd707a5e45bdf1972c94e3206b6e3 /net/ipv4/ip_output.c | |
parent | 07317621d004e8e6967f2dac8562825267e56135 (diff) |
[NETFILTER] bridge: simplify nf_bridge_pad
Do some simple optimization on the nf_bridge_pad() function
and don't use magic constants. Eliminate a double call and
the #ifdef'd code for CONFIG_BRIDGE_NETFILTER.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/ip_output.c')
-rw-r--r-- | net/ipv4/ip_output.c | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c index 81b2795a4c20..97aee76fb746 100644 --- a/net/ipv4/ip_output.c +++ b/net/ipv4/ip_output.c | |||
@@ -426,7 +426,7 @@ int ip_fragment(struct sk_buff *skb, int (*output)(struct sk_buff*)) | |||
426 | int ptr; | 426 | int ptr; |
427 | struct net_device *dev; | 427 | struct net_device *dev; |
428 | struct sk_buff *skb2; | 428 | struct sk_buff *skb2; |
429 | unsigned int mtu, hlen, left, len, ll_rs; | 429 | unsigned int mtu, hlen, left, len, ll_rs, pad; |
430 | int offset; | 430 | int offset; |
431 | __be16 not_last_frag; | 431 | __be16 not_last_frag; |
432 | struct rtable *rt = (struct rtable*)skb->dst; | 432 | struct rtable *rt = (struct rtable*)skb->dst; |
@@ -556,14 +556,13 @@ slow_path: | |||
556 | left = skb->len - hlen; /* Space per frame */ | 556 | left = skb->len - hlen; /* Space per frame */ |
557 | ptr = raw + hlen; /* Where to start from */ | 557 | ptr = raw + hlen; /* Where to start from */ |
558 | 558 | ||
559 | #ifdef CONFIG_BRIDGE_NETFILTER | ||
560 | /* for bridged IP traffic encapsulated inside f.e. a vlan header, | 559 | /* for bridged IP traffic encapsulated inside f.e. a vlan header, |
561 | * we need to make room for the encapsulating header */ | 560 | * we need to make room for the encapsulating header |
562 | ll_rs = LL_RESERVED_SPACE_EXTRA(rt->u.dst.dev, nf_bridge_pad(skb)); | 561 | */ |
563 | mtu -= nf_bridge_pad(skb); | 562 | pad = nf_bridge_pad(skb); |
564 | #else | 563 | ll_rs = LL_RESERVED_SPACE_EXTRA(rt->u.dst.dev, pad); |
565 | ll_rs = LL_RESERVED_SPACE(rt->u.dst.dev); | 564 | mtu -= pad; |
566 | #endif | 565 | |
567 | /* | 566 | /* |
568 | * Fragment the datagram. | 567 | * Fragment the datagram. |
569 | */ | 568 | */ |