diff options
author | Pavel Emelyanov <xemul@openvz.org> | 2007-12-11 05:12:36 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 17:57:08 -0500 |
commit | 95c9382a345262637d3e5c7da5f09f0f46daa930 (patch) | |
tree | 2572e9c338dbab9517cdd6b61174477b117796f9 /net/ipv4/inet_timewait_sock.c | |
parent | 1f9e636ea21bd648a5cbd2f744a1d39a5e183b20 (diff) |
[INET]: Use BUILD_BUG_ON in inet_timewait_sock.c checks
Make the INET_TWDR_TWKILL_SLOTS vs sizeof(twdr->thread_slots)
check nicer.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/inet_timewait_sock.c')
-rw-r--r-- | net/ipv4/inet_timewait_sock.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/net/ipv4/inet_timewait_sock.c b/net/ipv4/inet_timewait_sock.c index a60b99e0ebdc..d43e787031a4 100644 --- a/net/ipv4/inet_timewait_sock.c +++ b/net/ipv4/inet_timewait_sock.c | |||
@@ -194,16 +194,14 @@ out: | |||
194 | 194 | ||
195 | EXPORT_SYMBOL_GPL(inet_twdr_hangman); | 195 | EXPORT_SYMBOL_GPL(inet_twdr_hangman); |
196 | 196 | ||
197 | extern void twkill_slots_invalid(void); | ||
198 | |||
199 | void inet_twdr_twkill_work(struct work_struct *work) | 197 | void inet_twdr_twkill_work(struct work_struct *work) |
200 | { | 198 | { |
201 | struct inet_timewait_death_row *twdr = | 199 | struct inet_timewait_death_row *twdr = |
202 | container_of(work, struct inet_timewait_death_row, twkill_work); | 200 | container_of(work, struct inet_timewait_death_row, twkill_work); |
203 | int i; | 201 | int i; |
204 | 202 | ||
205 | if ((INET_TWDR_TWKILL_SLOTS - 1) > (sizeof(twdr->thread_slots) * 8)) | 203 | BUILD_BUG_ON((INET_TWDR_TWKILL_SLOTS - 1) > |
206 | twkill_slots_invalid(); | 204 | (sizeof(twdr->thread_slots) * 8)); |
207 | 205 | ||
208 | while (twdr->thread_slots) { | 206 | while (twdr->thread_slots) { |
209 | spin_lock_bh(&twdr->death_lock); | 207 | spin_lock_bh(&twdr->death_lock); |