inet: add proper refcounting to request sock

reqsk_put() is the generic function that should be used
to release a refcount (and automatically call reqsk_free())

reqsk_free() might be called if refcount is known to be 0
or undefined.

refcnt is set to one in inet_csk_reqsk_queue_add()

As request socks are not yet in global ehash table,
I added temporary debugging checks in reqsk_put() and reqsk_free()

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 4 insertions, 4 deletions

diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c
index 34581f928afa..3390ba6f96b2 100644
--- a/net/ipv4/inet_connection_sock.c
+++ b/net/ipv4/inet_connection_sock.c
@@ -340,7 +340,7 @@ struct sock *inet_csk_accept(struct sock *sk, int flags, int *err)
 out:
         release_sock(sk);
         if (req)
-                __reqsk_free(req);
+                reqsk_put(req);
         return newsk;
 out_err:
         newsk = NULL;
@@ -635,7 +635,7 @@ void inet_csk_reqsk_queue_prune(struct sock *parent,
                                 /* Drop this request */
                                 inet_csk_reqsk_queue_unlink(parent, req, reqp);
                                 reqsk_queue_removed(queue, req);
-                                reqsk_free(req);
+                                reqsk_put(req);
                                 continue;
                         }
                         reqp = &req->dl_next;
@@ -837,7 +837,7 @@ void inet_csk_listen_stop(struct sock *sk)
                 sock_put(child);
 
                 sk_acceptq_removed(sk);
-                __reqsk_free(req);
+                reqsk_put(req);
         }
         if (queue->fastopenq != NULL) {
                 /* Free all the reqs queued in rskq_rst_head. */
@@ -847,7 +847,7 @@ void inet_csk_listen_stop(struct sock *sk)
                 spin_unlock_bh(&queue->fastopenq->lock);
                 while ((req = acc_req) != NULL) {
                         acc_req = req->dl_next;
-                        __reqsk_free(req);
+                        reqsk_put(req);
                 }
         }
         WARN_ON(sk->sk_ack_backlog);