diff options
author | Stephen Hemminger <stephen.hemminger@vyatta.com> | 2008-01-12 23:58:35 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 18:01:55 -0500 |
commit | a6db9010922f2c02db2bbea8c17c50e451be38d9 (patch) | |
tree | e58cd43481a9bcc2f8b08b17d894776b04654188 /net/ipv4/fib_semantics.c | |
parent | fea86ad8123df0d49188cbc1dd2f48da6ae49d65 (diff) |
[IPV4] FIB: printk related cleanups
printk related cleanups:
* Get rid of unused printk wrappers.
* Make bug checks into KERN_WARNING because KERN_DEBUG gets ignored
* Turn one cryptic old message into something real
* Make sure all messages have KERN_XXX
Signed-off-by: Stephen Hemminger <stephen.hemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/fib_semantics.c')
-rw-r--r-- | net/ipv4/fib_semantics.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c index 0de6102020e2..3ed920b92fb6 100644 --- a/net/ipv4/fib_semantics.c +++ b/net/ipv4/fib_semantics.c | |||
@@ -47,8 +47,6 @@ | |||
47 | 47 | ||
48 | #include "fib_lookup.h" | 48 | #include "fib_lookup.h" |
49 | 49 | ||
50 | #define FSprintk(a...) | ||
51 | |||
52 | static DEFINE_SPINLOCK(fib_info_lock); | 50 | static DEFINE_SPINLOCK(fib_info_lock); |
53 | static struct hlist_head *fib_info_hash; | 51 | static struct hlist_head *fib_info_hash; |
54 | static struct hlist_head *fib_info_laddrhash; | 52 | static struct hlist_head *fib_info_laddrhash; |
@@ -145,7 +143,7 @@ static const struct | |||
145 | void free_fib_info(struct fib_info *fi) | 143 | void free_fib_info(struct fib_info *fi) |
146 | { | 144 | { |
147 | if (fi->fib_dead == 0) { | 145 | if (fi->fib_dead == 0) { |
148 | printk("Freeing alive fib_info %p\n", fi); | 146 | printk(KERN_WARNING "Freeing alive fib_info %p\n", fi); |
149 | return; | 147 | return; |
150 | } | 148 | } |
151 | change_nexthops(fi) { | 149 | change_nexthops(fi) { |
@@ -914,7 +912,8 @@ int fib_semantic_match(struct list_head *head, const struct flowi *flp, | |||
914 | continue; | 912 | continue; |
915 | 913 | ||
916 | default: | 914 | default: |
917 | printk(KERN_DEBUG "impossible 102\n"); | 915 | printk(KERN_WARNING "fib_semantic_match bad type %#x\n", |
916 | fa->fa_type); | ||
918 | return -EINVAL; | 917 | return -EINVAL; |
919 | } | 918 | } |
920 | } | 919 | } |