aboutsummaryrefslogtreecommitdiffstats
path: root/net/ipv4/af_inet.c
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2008-03-06 19:22:02 -0500
committerDavid S. Miller <davem@davemloft.net>2008-03-06 19:22:02 -0500
commitdb8dac20d5199307dcfcf4e01dac4bda5edf9e89 (patch)
tree3694d1aee5c0014fb45eec045a67ca150ca1231f /net/ipv4/af_inet.c
parentba0fa4599484b98dbb21d279fbfdb40e9c07d30d (diff)
[UDP]: Revert udplite and code split.
This reverts commit db1ed684f6c430c4cdad67d058688b8a1b5e607c ("[IPV6] UDP: Rename IPv6 UDP files."), commit 8be8af8fa4405652e6c0797db5465a4be8afb998 ("[IPV4] UDP: Move IPv4-specific bits to other file.") and commit e898d4db2749c6052072e9bc4448e396cbdeb06a ("[UDP]: Allow users to configure UDP-Lite."). First, udplite is of such small cost, and it is a core protocol just like TCP and normal UDP are. We spent enormous amounts of effort to make udplite share as much code with core UDP as possible. All of that work is less valuable if we're just going to slap a config option on udplite support. It is also causing build failures, as reported on linux-next, showing that the changeset was not tested very well. In fact, this is the second build failure resulting from the udplite change. Finally, the config options provided was a bool, instead of a modular option. Meaning the udplite code does not even get build tested by allmodconfig builds, and furthermore the user is not presented with a reasonable modular build option which is particularly needed by distribution vendors. Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/af_inet.c')
-rw-r--r--net/ipv4/af_inet.c7
1 files changed, 1 insertions, 6 deletions
diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
index 25871c6c7444..4cb8a1385539 100644
--- a/net/ipv4/af_inet.c
+++ b/net/ipv4/af_inet.c
@@ -1317,18 +1317,15 @@ static int __init init_ipv4_mibs(void)
1317 if (snmp_mib_init((void **)udp_statistics, 1317 if (snmp_mib_init((void **)udp_statistics,
1318 sizeof(struct udp_mib)) < 0) 1318 sizeof(struct udp_mib)) < 0)
1319 goto err_udp_mib; 1319 goto err_udp_mib;
1320#ifdef CONFIG_IP_UDPLITE
1321 if (snmp_mib_init((void **)udplite_statistics, 1320 if (snmp_mib_init((void **)udplite_statistics,
1322 sizeof(struct udp_mib)) < 0) 1321 sizeof(struct udp_mib)) < 0)
1323 goto err_udplite_mib; 1322 goto err_udplite_mib;
1324#endif 1323
1325 tcp_mib_init(); 1324 tcp_mib_init();
1326 1325
1327 return 0; 1326 return 0;
1328 1327
1329#ifdef CONFIG_IP_UDPLITE
1330err_udplite_mib: 1328err_udplite_mib:
1331#endif
1332 snmp_mib_free((void **)udp_statistics); 1329 snmp_mib_free((void **)udp_statistics);
1333err_udp_mib: 1330err_udp_mib:
1334 snmp_mib_free((void **)tcp_statistics); 1331 snmp_mib_free((void **)tcp_statistics);
@@ -1426,10 +1423,8 @@ static int __init inet_init(void)
1426 /* Setup UDP memory threshold */ 1423 /* Setup UDP memory threshold */
1427 udp_init(); 1424 udp_init();
1428 1425
1429#ifdef CONFIG_IP_UDPLITE
1430 /* Add UDP-Lite (RFC 3828) */ 1426 /* Add UDP-Lite (RFC 3828) */
1431 udplite4_register(); 1427 udplite4_register();
1432#endif
1433 1428
1434 /* 1429 /*
1435 * Set the ICMP layer up 1430 * Set the ICMP layer up