diff options
author | stephen hemminger <stephen@networkplumber.org> | 2013-09-27 20:21:27 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-10-01 00:52:53 -0400 |
commit | 56d7b53f47e7c9a0ab1c6289f2669a8d3a65cf17 (patch) | |
tree | d07ed00e0c65e64622b53182ad063e7cd51675c4 /net/ethernet | |
parent | 12861b7bc2a32f7d36cdbc2ab5236819fa203836 (diff) |
ethernet: use likely() for common Ethernet encap
Mark code path's likely/unlikely based on most common usage.
* Very few devices use dsa tags.
* Most traffic is Ethernet (not 802.2)
* No sane person uses trailer type or Novell encapsulation
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ethernet')
-rw-r--r-- | net/ethernet/eth.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c index f777e17d28c8..8f032bae60ad 100644 --- a/net/ethernet/eth.c +++ b/net/ethernet/eth.c | |||
@@ -179,12 +179,13 @@ __be16 eth_type_trans(struct sk_buff *skb, struct net_device *dev) | |||
179 | * variants has been configured on the receiving interface, | 179 | * variants has been configured on the receiving interface, |
180 | * and if so, set skb->protocol without looking at the packet. | 180 | * and if so, set skb->protocol without looking at the packet. |
181 | */ | 181 | */ |
182 | if (netdev_uses_dsa_tags(dev)) | 182 | if (unlikely(netdev_uses_dsa_tags(dev))) |
183 | return htons(ETH_P_DSA); | 183 | return htons(ETH_P_DSA); |
184 | if (netdev_uses_trailer_tags(dev)) | 184 | |
185 | if (unlikely(netdev_uses_trailer_tags(dev))) | ||
185 | return htons(ETH_P_TRAILER); | 186 | return htons(ETH_P_TRAILER); |
186 | 187 | ||
187 | if (ntohs(eth->h_proto) >= ETH_P_802_3_MIN) | 188 | if (likely(ntohs(eth->h_proto) >= ETH_P_802_3_MIN)) |
188 | return eth->h_proto; | 189 | return eth->h_proto; |
189 | 190 | ||
190 | /* | 191 | /* |
@@ -193,7 +194,7 @@ __be16 eth_type_trans(struct sk_buff *skb, struct net_device *dev) | |||
193 | * layer. We look for FFFF which isn't a used 802.2 SSAP/DSAP. This | 194 | * layer. We look for FFFF which isn't a used 802.2 SSAP/DSAP. This |
194 | * won't work for fault tolerant netware but does for the rest. | 195 | * won't work for fault tolerant netware but does for the rest. |
195 | */ | 196 | */ |
196 | if (skb->len >= 2 && *(unsigned short *)(skb->data) == 0xFFFF) | 197 | if (unlikely(skb->len >= 2 && *(unsigned short *)(skb->data) == 0xFFFF)) |
197 | return htons(ETH_P_802_3); | 198 | return htons(ETH_P_802_3); |
198 | 199 | ||
199 | /* | 200 | /* |