diff options
author | Akinobu Mita <akinobu.mita@gmail.com> | 2010-08-27 12:41:56 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-08-28 18:37:03 -0400 |
commit | 762c29164e2850d8c5e4c258cef0077b2584d111 (patch) | |
tree | 4cb5c25ce87578386f751dbcd3e46b6eba3cb716 /net/econet | |
parent | 034de00b06fe2b2c451f7435414f15c1b625e6b0 (diff) |
econet: kill unnecessary spin_lock_init()
The spinlock aun_queue_lock is initialized statically. It is unnecessary
to initialize by spin_lock_init() at module load time.
This is detected by the semantic patch.
// <smpl>
@def@
declarer name DEFINE_SPINLOCK;
identifier spinlock;
@@
DEFINE_SPINLOCK(spinlock);
@@
identifier def.spinlock;
@@
- spin_lock_init(&spinlock);
// </smpl>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Julia Lawall <julia@diku.dk>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/econet')
-rw-r--r-- | net/econet/af_econet.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/net/econet/af_econet.c b/net/econet/af_econet.c index dc54bd0d083b..baa98fb83552 100644 --- a/net/econet/af_econet.c +++ b/net/econet/af_econet.c | |||
@@ -1009,7 +1009,6 @@ static int __init aun_udp_initialise(void) | |||
1009 | struct sockaddr_in sin; | 1009 | struct sockaddr_in sin; |
1010 | 1010 | ||
1011 | skb_queue_head_init(&aun_queue); | 1011 | skb_queue_head_init(&aun_queue); |
1012 | spin_lock_init(&aun_queue_lock); | ||
1013 | setup_timer(&ab_cleanup_timer, ab_cleanup, 0); | 1012 | setup_timer(&ab_cleanup_timer, ab_cleanup, 0); |
1014 | ab_cleanup_timer.expires = jiffies + (HZ*2); | 1013 | ab_cleanup_timer.expires = jiffies + (HZ*2); |
1015 | add_timer(&ab_cleanup_timer); | 1014 | add_timer(&ab_cleanup_timer); |
@@ -1167,7 +1166,6 @@ static int __init econet_proto_init(void) | |||
1167 | goto out; | 1166 | goto out; |
1168 | sock_register(&econet_family_ops); | 1167 | sock_register(&econet_family_ops); |
1169 | #ifdef CONFIG_ECONET_AUNUDP | 1168 | #ifdef CONFIG_ECONET_AUNUDP |
1170 | spin_lock_init(&aun_queue_lock); | ||
1171 | aun_udp_initialise(); | 1169 | aun_udp_initialise(); |
1172 | #endif | 1170 | #endif |
1173 | #ifdef CONFIG_ECONET_NATIVE | 1171 | #ifdef CONFIG_ECONET_NATIVE |