aboutsummaryrefslogtreecommitdiffstats
path: root/net/decnet
diff options
context:
space:
mode:
authorstephen hemminger <shemminger@vyatta.com>2009-11-11 02:39:27 -0500
committerDavid S. Miller <davem@davemloft.net>2009-11-11 22:22:15 -0500
commit41bdecf17e6dba92256c65972ec79a482d978be5 (patch)
treef0fb46bda6bc72483a30bb726cf35ffdf77cbf0c /net/decnet
parent08e9897d512fe7a67e46209543b3815b57a36dc7 (diff)
decnet: add RTNL lock when reading address list
Add missing locking in the case of auto binding to the default device. The address list might change while this code is looking at the list. Compile tested only, I am not a decnet user. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/decnet')
-rw-r--r--net/decnet/dn_dev.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/net/decnet/dn_dev.c b/net/decnet/dn_dev.c
index b5ef237c8a74..5790d660bc7d 100644
--- a/net/decnet/dn_dev.c
+++ b/net/decnet/dn_dev.c
@@ -828,13 +828,17 @@ static int dn_dev_get_first(struct net_device *dev, __le16 *addr)
828 struct dn_dev *dn_db = (struct dn_dev *)dev->dn_ptr; 828 struct dn_dev *dn_db = (struct dn_dev *)dev->dn_ptr;
829 struct dn_ifaddr *ifa; 829 struct dn_ifaddr *ifa;
830 int rv = -ENODEV; 830 int rv = -ENODEV;
831
831 if (dn_db == NULL) 832 if (dn_db == NULL)
832 goto out; 833 goto out;
834
835 rtnl_lock();
833 ifa = dn_db->ifa_list; 836 ifa = dn_db->ifa_list;
834 if (ifa != NULL) { 837 if (ifa != NULL) {
835 *addr = ifa->ifa_local; 838 *addr = ifa->ifa_local;
836 rv = 0; 839 rv = 0;
837 } 840 }
841 rtnl_unlock();
838out: 842out:
839 return rv; 843 return rv;
840} 844}