diff options
author | Eric W. Biederman <ebiederm@xmission.com> | 2012-11-15 22:03:00 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-11-18 20:32:44 -0500 |
commit | dfc47ef8639facd77210e74be831943c2fdd9c74 (patch) | |
tree | 5c7e9f93a999bf1d38b216af346ce2159e5f18ec /net/decnet | |
parent | 464dc801c76aa0db88e16e8f5f47c6879858b9b2 (diff) |
net: Push capable(CAP_NET_ADMIN) into the rtnl methods
- In rtnetlink_rcv_msg convert the capable(CAP_NET_ADMIN) check
to ns_capable(net->user-ns, CAP_NET_ADMIN). Allowing unprivileged
users to make netlink calls to modify their local network
namespace.
- In the rtnetlink doit methods add capable(CAP_NET_ADMIN) so
that calls that are not safe for unprivileged users are still
protected.
Later patches will remove the extra capable calls from methods
that are safe for unprivilged users.
Acked-by: Serge Hallyn <serge.hallyn@canonical.com>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/decnet')
-rw-r--r-- | net/decnet/dn_dev.c | 6 | ||||
-rw-r--r-- | net/decnet/dn_fib.c | 6 |
2 files changed, 12 insertions, 0 deletions
diff --git a/net/decnet/dn_dev.c b/net/decnet/dn_dev.c index 7b7e561412d3..e47ba9fc4a0e 100644 --- a/net/decnet/dn_dev.c +++ b/net/decnet/dn_dev.c | |||
@@ -573,6 +573,9 @@ static int dn_nl_deladdr(struct sk_buff *skb, struct nlmsghdr *nlh, void *arg) | |||
573 | struct dn_ifaddr __rcu **ifap; | 573 | struct dn_ifaddr __rcu **ifap; |
574 | int err = -EINVAL; | 574 | int err = -EINVAL; |
575 | 575 | ||
576 | if (!capable(CAP_NET_ADMIN)) | ||
577 | return -EPERM; | ||
578 | |||
576 | if (!net_eq(net, &init_net)) | 579 | if (!net_eq(net, &init_net)) |
577 | goto errout; | 580 | goto errout; |
578 | 581 | ||
@@ -614,6 +617,9 @@ static int dn_nl_newaddr(struct sk_buff *skb, struct nlmsghdr *nlh, void *arg) | |||
614 | struct dn_ifaddr *ifa; | 617 | struct dn_ifaddr *ifa; |
615 | int err; | 618 | int err; |
616 | 619 | ||
620 | if (!capable(CAP_NET_ADMIN)) | ||
621 | return -EPERM; | ||
622 | |||
617 | if (!net_eq(net, &init_net)) | 623 | if (!net_eq(net, &init_net)) |
618 | return -EINVAL; | 624 | return -EINVAL; |
619 | 625 | ||
diff --git a/net/decnet/dn_fib.c b/net/decnet/dn_fib.c index 102d6106a942..e36614eccc04 100644 --- a/net/decnet/dn_fib.c +++ b/net/decnet/dn_fib.c | |||
@@ -520,6 +520,9 @@ static int dn_fib_rtm_delroute(struct sk_buff *skb, struct nlmsghdr *nlh, void * | |||
520 | struct rtattr **rta = arg; | 520 | struct rtattr **rta = arg; |
521 | struct rtmsg *r = NLMSG_DATA(nlh); | 521 | struct rtmsg *r = NLMSG_DATA(nlh); |
522 | 522 | ||
523 | if (!capable(CAP_NET_ADMIN)) | ||
524 | return -EPERM; | ||
525 | |||
523 | if (!net_eq(net, &init_net)) | 526 | if (!net_eq(net, &init_net)) |
524 | return -EINVAL; | 527 | return -EINVAL; |
525 | 528 | ||
@@ -540,6 +543,9 @@ static int dn_fib_rtm_newroute(struct sk_buff *skb, struct nlmsghdr *nlh, void * | |||
540 | struct rtattr **rta = arg; | 543 | struct rtattr **rta = arg; |
541 | struct rtmsg *r = NLMSG_DATA(nlh); | 544 | struct rtmsg *r = NLMSG_DATA(nlh); |
542 | 545 | ||
546 | if (!capable(CAP_NET_ADMIN)) | ||
547 | return -EPERM; | ||
548 | |||
543 | if (!net_eq(net, &init_net)) | 549 | if (!net_eq(net, &init_net)) |
544 | return -EINVAL; | 550 | return -EINVAL; |
545 | 551 | ||