diff options
author | Jamal Hadi Salim <hadi@cyberus.ca> | 2005-06-19 01:54:12 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2005-06-19 01:54:12 -0400 |
commit | b6544c0b4cf2bd96195f3cdb7cebfb35090fc557 (patch) | |
tree | 717f69a0c204b12eeedb8035fb66c8e9bb2d5a09 /net/decnet/dn_table.c | |
parent | 1797754ea7ee5e0d859b0a32506ff999f8d5fb71 (diff) |
[NETLINK]: Correctly set NLM_F_MULTI without checking the pid
This patch rectifies some rtnetlink message builders that derive the
flags from the pid. It is now explicit like the other cases
which get it right. Also fixes half a dozen dumpers which did not
set NLM_F_MULTI at all.
Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/decnet/dn_table.c')
-rw-r--r-- | net/decnet/dn_table.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/net/decnet/dn_table.c b/net/decnet/dn_table.c index dad5603912be..28ba5777a25a 100644 --- a/net/decnet/dn_table.c +++ b/net/decnet/dn_table.c | |||
@@ -270,13 +270,13 @@ static int dn_fib_nh_match(struct rtmsg *r, struct nlmsghdr *nlh, struct dn_kern | |||
270 | 270 | ||
271 | static int dn_fib_dump_info(struct sk_buff *skb, u32 pid, u32 seq, int event, | 271 | static int dn_fib_dump_info(struct sk_buff *skb, u32 pid, u32 seq, int event, |
272 | u8 tb_id, u8 type, u8 scope, void *dst, int dst_len, | 272 | u8 tb_id, u8 type, u8 scope, void *dst, int dst_len, |
273 | struct dn_fib_info *fi) | 273 | struct dn_fib_info *fi, unsigned int flags) |
274 | { | 274 | { |
275 | struct rtmsg *rtm; | 275 | struct rtmsg *rtm; |
276 | struct nlmsghdr *nlh; | 276 | struct nlmsghdr *nlh; |
277 | unsigned char *b = skb->tail; | 277 | unsigned char *b = skb->tail; |
278 | 278 | ||
279 | nlh = NLMSG_PUT(skb, pid, seq, event, sizeof(*rtm)); | 279 | nlh = NLMSG_NEW(skb, pid, seq, event, sizeof(*rtm), flags); |
280 | rtm = NLMSG_DATA(nlh); | 280 | rtm = NLMSG_DATA(nlh); |
281 | rtm->rtm_family = AF_DECnet; | 281 | rtm->rtm_family = AF_DECnet; |
282 | rtm->rtm_dst_len = dst_len; | 282 | rtm->rtm_dst_len = dst_len; |
@@ -345,7 +345,7 @@ static void dn_rtmsg_fib(int event, struct dn_fib_node *f, int z, int tb_id, | |||
345 | 345 | ||
346 | if (dn_fib_dump_info(skb, pid, nlh->nlmsg_seq, event, tb_id, | 346 | if (dn_fib_dump_info(skb, pid, nlh->nlmsg_seq, event, tb_id, |
347 | f->fn_type, f->fn_scope, &f->fn_key, z, | 347 | f->fn_type, f->fn_scope, &f->fn_key, z, |
348 | DN_FIB_INFO(f)) < 0) { | 348 | DN_FIB_INFO(f), 0) < 0) { |
349 | kfree_skb(skb); | 349 | kfree_skb(skb); |
350 | return; | 350 | return; |
351 | } | 351 | } |
@@ -377,7 +377,7 @@ static __inline__ int dn_hash_dump_bucket(struct sk_buff *skb, | |||
377 | tb->n, | 377 | tb->n, |
378 | (f->fn_state & DN_S_ZOMBIE) ? 0 : f->fn_type, | 378 | (f->fn_state & DN_S_ZOMBIE) ? 0 : f->fn_type, |
379 | f->fn_scope, &f->fn_key, dz->dz_order, | 379 | f->fn_scope, &f->fn_key, dz->dz_order, |
380 | f->fn_info) < 0) { | 380 | f->fn_info, NLM_F_MULTI) < 0) { |
381 | cb->args[3] = i; | 381 | cb->args[3] = i; |
382 | return -1; | 382 | return -1; |
383 | } | 383 | } |