diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2008-07-26 23:17:56 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-07-26 23:17:56 -0400 |
commit | 228428428138e231a155464239880201e5cc8b44 (patch) | |
tree | 89b437f5501d03ca36b717e232337426d0de77ca /net/dccp | |
parent | 78681ac08a611313595d13cafabae1183b71ef48 (diff) | |
parent | 6c3b8fc618905d7599dcc514c99ce4293d476f39 (diff) |
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6
* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6:
netns: fix ip_rt_frag_needed rt_is_expired
netfilter: nf_conntrack_extend: avoid unnecessary "ct->ext" dereferences
netfilter: fix double-free and use-after free
netfilter: arptables in netns for real
netfilter: ip{,6}tables_security: fix future section mismatch
selinux: use nf_register_hooks()
netfilter: ebtables: use nf_register_hooks()
Revert "pkt_sched: sch_sfq: dump a real number of flows"
qeth: use dev->ml_priv instead of dev->priv
syncookies: Make sure ECN is disabled
net: drop unused BUG_TRAP()
net: convert BUG_TRAP to generic WARN_ON
drivers/net: convert BUG_TRAP to generic WARN_ON
Diffstat (limited to 'net/dccp')
-rw-r--r-- | net/dccp/dccp.h | 2 | ||||
-rw-r--r-- | net/dccp/input.c | 2 | ||||
-rw-r--r-- | net/dccp/ipv4.c | 2 | ||||
-rw-r--r-- | net/dccp/ipv6.c | 2 | ||||
-rw-r--r-- | net/dccp/proto.c | 4 | ||||
-rw-r--r-- | net/dccp/timer.c | 2 |
6 files changed, 7 insertions, 7 deletions
diff --git a/net/dccp/dccp.h b/net/dccp/dccp.h index 32617e0576cb..743d85fcd651 100644 --- a/net/dccp/dccp.h +++ b/net/dccp/dccp.h | |||
@@ -164,7 +164,7 @@ static inline bool dccp_loss_free(const u64 s1, const u64 s2, const u64 ndp) | |||
164 | { | 164 | { |
165 | s64 delta = dccp_delta_seqno(s1, s2); | 165 | s64 delta = dccp_delta_seqno(s1, s2); |
166 | 166 | ||
167 | BUG_TRAP(delta >= 0); | 167 | WARN_ON(delta < 0); |
168 | return (u64)delta <= ndp + 1; | 168 | return (u64)delta <= ndp + 1; |
169 | } | 169 | } |
170 | 170 | ||
diff --git a/net/dccp/input.c b/net/dccp/input.c index 08392ed86c25..df2f110df94a 100644 --- a/net/dccp/input.c +++ b/net/dccp/input.c | |||
@@ -413,7 +413,7 @@ static int dccp_rcv_request_sent_state_process(struct sock *sk, | |||
413 | 413 | ||
414 | /* Stop the REQUEST timer */ | 414 | /* Stop the REQUEST timer */ |
415 | inet_csk_clear_xmit_timer(sk, ICSK_TIME_RETRANS); | 415 | inet_csk_clear_xmit_timer(sk, ICSK_TIME_RETRANS); |
416 | BUG_TRAP(sk->sk_send_head != NULL); | 416 | WARN_ON(sk->sk_send_head == NULL); |
417 | __kfree_skb(sk->sk_send_head); | 417 | __kfree_skb(sk->sk_send_head); |
418 | sk->sk_send_head = NULL; | 418 | sk->sk_send_head = NULL; |
419 | 419 | ||
diff --git a/net/dccp/ipv4.c b/net/dccp/ipv4.c index 2622ace17c46..a835b88237cb 100644 --- a/net/dccp/ipv4.c +++ b/net/dccp/ipv4.c | |||
@@ -283,7 +283,7 @@ static void dccp_v4_err(struct sk_buff *skb, u32 info) | |||
283 | * ICMPs are not backlogged, hence we cannot get an established | 283 | * ICMPs are not backlogged, hence we cannot get an established |
284 | * socket here. | 284 | * socket here. |
285 | */ | 285 | */ |
286 | BUG_TRAP(!req->sk); | 286 | WARN_ON(req->sk); |
287 | 287 | ||
288 | if (seq != dccp_rsk(req)->dreq_iss) { | 288 | if (seq != dccp_rsk(req)->dreq_iss) { |
289 | NET_INC_STATS_BH(net, LINUX_MIB_OUTOFWINDOWICMPS); | 289 | NET_INC_STATS_BH(net, LINUX_MIB_OUTOFWINDOWICMPS); |
diff --git a/net/dccp/ipv6.c b/net/dccp/ipv6.c index b74e8b2cbe55..da509127e00c 100644 --- a/net/dccp/ipv6.c +++ b/net/dccp/ipv6.c | |||
@@ -186,7 +186,7 @@ static void dccp_v6_err(struct sk_buff *skb, struct inet6_skb_parm *opt, | |||
186 | * ICMPs are not backlogged, hence we cannot get an established | 186 | * ICMPs are not backlogged, hence we cannot get an established |
187 | * socket here. | 187 | * socket here. |
188 | */ | 188 | */ |
189 | BUG_TRAP(req->sk == NULL); | 189 | WARN_ON(req->sk != NULL); |
190 | 190 | ||
191 | if (seq != dccp_rsk(req)->dreq_iss) { | 191 | if (seq != dccp_rsk(req)->dreq_iss) { |
192 | NET_INC_STATS_BH(net, LINUX_MIB_OUTOFWINDOWICMPS); | 192 | NET_INC_STATS_BH(net, LINUX_MIB_OUTOFWINDOWICMPS); |
diff --git a/net/dccp/proto.c b/net/dccp/proto.c index a0b56009611f..b622d9744856 100644 --- a/net/dccp/proto.c +++ b/net/dccp/proto.c | |||
@@ -327,7 +327,7 @@ int dccp_disconnect(struct sock *sk, int flags) | |||
327 | inet_csk_delack_init(sk); | 327 | inet_csk_delack_init(sk); |
328 | __sk_dst_reset(sk); | 328 | __sk_dst_reset(sk); |
329 | 329 | ||
330 | BUG_TRAP(!inet->num || icsk->icsk_bind_hash); | 330 | WARN_ON(inet->num && !icsk->icsk_bind_hash); |
331 | 331 | ||
332 | sk->sk_error_report(sk); | 332 | sk->sk_error_report(sk); |
333 | return err; | 333 | return err; |
@@ -981,7 +981,7 @@ adjudge_to_death: | |||
981 | */ | 981 | */ |
982 | local_bh_disable(); | 982 | local_bh_disable(); |
983 | bh_lock_sock(sk); | 983 | bh_lock_sock(sk); |
984 | BUG_TRAP(!sock_owned_by_user(sk)); | 984 | WARN_ON(sock_owned_by_user(sk)); |
985 | 985 | ||
986 | /* Have we already been destroyed by a softirq or backlog? */ | 986 | /* Have we already been destroyed by a softirq or backlog? */ |
987 | if (state != DCCP_CLOSED && sk->sk_state == DCCP_CLOSED) | 987 | if (state != DCCP_CLOSED && sk->sk_state == DCCP_CLOSED) |
diff --git a/net/dccp/timer.c b/net/dccp/timer.c index 3608d5342ca2..6a5b961b6f5c 100644 --- a/net/dccp/timer.c +++ b/net/dccp/timer.c | |||
@@ -106,7 +106,7 @@ static void dccp_retransmit_timer(struct sock *sk) | |||
106 | * -- Acks in client-PARTOPEN state (sec. 8.1.5) | 106 | * -- Acks in client-PARTOPEN state (sec. 8.1.5) |
107 | * -- CloseReq in server-CLOSEREQ state (sec. 8.3) | 107 | * -- CloseReq in server-CLOSEREQ state (sec. 8.3) |
108 | * -- Close in node-CLOSING state (sec. 8.3) */ | 108 | * -- Close in node-CLOSING state (sec. 8.3) */ |
109 | BUG_TRAP(sk->sk_send_head != NULL); | 109 | WARN_ON(sk->sk_send_head == NULL); |
110 | 110 | ||
111 | /* | 111 | /* |
112 | * More than than 4MSL (8 minutes) has passed, a RESET(aborted) was | 112 | * More than than 4MSL (8 minutes) has passed, a RESET(aborted) was |