aboutsummaryrefslogtreecommitdiffstats
path: root/net/dccp/proto.c
diff options
context:
space:
mode:
authorGerrit Renker <gerrit@erg.abdn.ac.uk>2008-09-04 01:30:19 -0400
committerGerrit Renker <gerrit@erg.abdn.ac.uk>2008-09-04 01:45:28 -0400
commitfade756f18d42694e3acb00e3471ab43002cba16 (patch)
treef2ae912af9678315b672eb292ef17de42a97fbf3 /net/dccp/proto.c
parent73bbe095bbb9ce5f94d5475bad54c7ccd8573b1b (diff)
dccp: Set per-connection CCIDs via socket options
With this patch, TX/RX CCIDs can now be changed on a per-connection basis, which overrides the defaults set by the global sysctl variables for TX/RX CCIDs. To make full use of this facility, the remaining patches of this patch set are needed, which track dependencies and activate negotiated feature values. Note on the maximum number of CCIDs that can be registered: ----------------------------------------------------------- The maximum number of CCIDs that can be registered on the socket is constrained by the space in a Confirm/Change feature negotiation option. The space in these in turn depends on the size of header options as defined in RFC 4340, 5.8. Since this is a recurring constant, it has been moved from ackvec.h into linux/dccp.h, clarifying its purpose. Relative to this size, the maximum number of CCID identifiers that can be present in a Confirm option (which always consumes 1 byte more than a Change option, cf. 6.1) is 2 bytes less than the maximum TLV size: one for the CCID-feature-type and one for the selected value. Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Diffstat (limited to 'net/dccp/proto.c')
-rw-r--r--net/dccp/proto.c34
1 files changed, 34 insertions, 0 deletions
diff --git a/net/dccp/proto.c b/net/dccp/proto.c
index e29bbf914057..2cd56df44d8e 100644
--- a/net/dccp/proto.c
+++ b/net/dccp/proto.c
@@ -506,6 +506,36 @@ static int dccp_setsockopt_cscov(struct sock *sk, int cscov, bool rx)
506 return rc; 506 return rc;
507} 507}
508 508
509static int dccp_setsockopt_ccid(struct sock *sk, int type,
510 char __user *optval, int optlen)
511{
512 u8 *val;
513 int rc = 0;
514
515 if (optlen < 1 || optlen > DCCP_FEAT_MAX_SP_VALS)
516 return -EINVAL;
517
518 val = kmalloc(optlen, GFP_KERNEL);
519 if (val == NULL)
520 return -ENOMEM;
521
522 if (copy_from_user(val, optval, optlen)) {
523 kfree(val);
524 return -EFAULT;
525 }
526
527 lock_sock(sk);
528 if (type == DCCP_SOCKOPT_TX_CCID || type == DCCP_SOCKOPT_CCID)
529 rc = dccp_feat_register_sp(sk, DCCPF_CCID, 1, val, optlen);
530
531 if (!rc && (type == DCCP_SOCKOPT_RX_CCID || type == DCCP_SOCKOPT_CCID))
532 rc = dccp_feat_register_sp(sk, DCCPF_CCID, 0, val, optlen);
533 release_sock(sk);
534
535 kfree(val);
536 return rc;
537}
538
509static int do_dccp_setsockopt(struct sock *sk, int level, int optname, 539static int do_dccp_setsockopt(struct sock *sk, int level, int optname,
510 char __user *optval, int optlen) 540 char __user *optval, int optlen)
511{ 541{
@@ -520,6 +550,10 @@ static int do_dccp_setsockopt(struct sock *sk, int level, int optname,
520 case DCCP_SOCKOPT_CHANGE_R: 550 case DCCP_SOCKOPT_CHANGE_R:
521 DCCP_WARN("sockopt(CHANGE_L/R) is deprecated: fix your app\n"); 551 DCCP_WARN("sockopt(CHANGE_L/R) is deprecated: fix your app\n");
522 return 0; 552 return 0;
553 case DCCP_SOCKOPT_CCID:
554 case DCCP_SOCKOPT_RX_CCID:
555 case DCCP_SOCKOPT_TX_CCID:
556 return dccp_setsockopt_ccid(sk, optname, optval, optlen);
523 } 557 }
524 558
525 if (optlen < (int)sizeof(int)) 559 if (optlen < (int)sizeof(int))