aboutsummaryrefslogtreecommitdiffstats
path: root/net/dccp/output.c
diff options
context:
space:
mode:
authorDavid S. Miller <davem@sunset.davemloft.net>2006-11-09 22:58:25 -0500
committerDavid S. Miller <davem@sunset.davemloft.net>2006-12-03 00:21:52 -0500
commit931731123a103cfb3f70ac4b7abfc71d94ba1f03 (patch)
tree0af6636fde05f74a8aa5421bfe9828e2a209170d /net/dccp/output.c
parentef56e622c61e74dd6077615c9ea76c5132195880 (diff)
[TCP]: Don't set SKB owner in tcp_transmit_skb().
The data itself is already charged to the SKB, doing the skb_set_owner_w() just generates a lot of noise and extra atomics we don't really need. Lmbench improvements on lat_tcp are minimal: before: TCP latency using localhost: 23.2701 microseconds TCP latency using localhost: 23.1994 microseconds TCP latency using localhost: 23.2257 microseconds after: TCP latency using localhost: 22.8380 microseconds TCP latency using localhost: 22.9465 microseconds TCP latency using localhost: 22.8462 microseconds Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dccp/output.c')
-rw-r--r--net/dccp/output.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/net/dccp/output.c b/net/dccp/output.c
index 7102e3aed4ca..2cc4f4b2a9dd 100644
--- a/net/dccp/output.c
+++ b/net/dccp/output.c
@@ -125,7 +125,7 @@ static int dccp_transmit_skb(struct sock *sk, struct sk_buff *skb)
125 DCCP_INC_STATS(DCCP_MIB_OUTSEGS); 125 DCCP_INC_STATS(DCCP_MIB_OUTSEGS);
126 126
127 memset(&(IPCB(skb)->opt), 0, sizeof(IPCB(skb)->opt)); 127 memset(&(IPCB(skb)->opt), 0, sizeof(IPCB(skb)->opt));
128 err = icsk->icsk_af_ops->queue_xmit(skb, 0); 128 err = icsk->icsk_af_ops->queue_xmit(skb, sk, 0);
129 if (err <= 0) 129 if (err <= 0)
130 return err; 130 return err;
131 131
@@ -426,7 +426,7 @@ int dccp_send_reset(struct sock *sk, enum dccp_reset_codes code)
426 code); 426 code);
427 if (skb != NULL) { 427 if (skb != NULL) {
428 memset(&(IPCB(skb)->opt), 0, sizeof(IPCB(skb)->opt)); 428 memset(&(IPCB(skb)->opt), 0, sizeof(IPCB(skb)->opt));
429 err = inet_csk(sk)->icsk_af_ops->queue_xmit(skb, 0); 429 err = inet_csk(sk)->icsk_af_ops->queue_xmit(skb, sk, 0);
430 if (err == NET_XMIT_CN) 430 if (err == NET_XMIT_CN)
431 err = 0; 431 err = 0;
432 } 432 }