aboutsummaryrefslogtreecommitdiffstats
path: root/net/dccp/minisocks.c
diff options
context:
space:
mode:
authorGerrit Renker <gerrit@erg.abdn.ac.uk>2006-11-10 09:32:01 -0500
committerDavid S. Miller <davem@sunset.davemloft.net>2006-12-03 00:21:58 -0500
commit8a73cd09d96aa01743316657fc4e6864fe79b703 (patch)
treefa22ed8ac78c5c76cc8ee3afd8bf72607290d42d /net/dccp/minisocks.c
parentf6484f7c7ad22e4bb018875c386d6a7aaa441426 (diff)
[DCCP]: calling dccp_v{4,6}_reqsk_send_ack is a BUG
This patch removes two functions, the send_ack functions of request_sock, which are not called/used by the DCCP code. It is correct that these functions are not called, below is a justification why calling these functions (on a passive socket in the LISTEN/RESPOND state) would mean a DCCP protocol violation. A) Background: using request_sock in TCP:
Diffstat (limited to 'net/dccp/minisocks.c')
-rw-r--r--net/dccp/minisocks.c10
1 files changed, 10 insertions, 0 deletions
diff --git a/net/dccp/minisocks.c b/net/dccp/minisocks.c
index 9045438d6b36..5f3e1a4c036b 100644
--- a/net/dccp/minisocks.c
+++ b/net/dccp/minisocks.c
@@ -11,6 +11,7 @@
11 */ 11 */
12 12
13#include <linux/dccp.h> 13#include <linux/dccp.h>
14#include <linux/kernel.h>
14#include <linux/skbuff.h> 15#include <linux/skbuff.h>
15#include <linux/timer.h> 16#include <linux/timer.h>
16 17
@@ -283,3 +284,12 @@ int dccp_child_process(struct sock *parent, struct sock *child,
283} 284}
284 285
285EXPORT_SYMBOL_GPL(dccp_child_process); 286EXPORT_SYMBOL_GPL(dccp_child_process);
287
288void dccp_reqsk_send_ack(struct sk_buff *skb, struct request_sock *rsk)
289{
290 pr_info(KERN_WARNING "DCCP: ACK packets are never sent in "
291 "LISTEN/RESPOND state\n");
292 dump_stack();
293}
294
295EXPORT_SYMBOL_GPL(dccp_reqsk_send_ack);