aboutsummaryrefslogtreecommitdiffstats
path: root/net/dccp/dccp.h
diff options
context:
space:
mode:
authorGerrit Renker <gerrit@erg.abdn.ac.uk>2006-11-10 09:32:01 -0500
committerDavid S. Miller <davem@sunset.davemloft.net>2006-12-03 00:21:58 -0500
commit8a73cd09d96aa01743316657fc4e6864fe79b703 (patch)
treefa22ed8ac78c5c76cc8ee3afd8bf72607290d42d /net/dccp/dccp.h
parentf6484f7c7ad22e4bb018875c386d6a7aaa441426 (diff)
[DCCP]: calling dccp_v{4,6}_reqsk_send_ack is a BUG
This patch removes two functions, the send_ack functions of request_sock, which are not called/used by the DCCP code. It is correct that these functions are not called, below is a justification why calling these functions (on a passive socket in the LISTEN/RESPOND state) would mean a DCCP protocol violation. A) Background: using request_sock in TCP:
Diffstat (limited to 'net/dccp/dccp.h')
-rw-r--r--net/dccp/dccp.h2
1 files changed, 2 insertions, 0 deletions
diff --git a/net/dccp/dccp.h b/net/dccp/dccp.h
index 8964b188aba3..3d4b4a908d11 100644
--- a/net/dccp/dccp.h
+++ b/net/dccp/dccp.h
@@ -131,6 +131,8 @@ extern int dccp_retransmit_skb(struct sock *sk, struct sk_buff *skb);
131 131
132extern void dccp_send_ack(struct sock *sk); 132extern void dccp_send_ack(struct sock *sk);
133extern void dccp_send_delayed_ack(struct sock *sk); 133extern void dccp_send_delayed_ack(struct sock *sk);
134extern void dccp_reqsk_send_ack(struct sk_buff *sk, struct request_sock *rsk);
135
134extern void dccp_send_sync(struct sock *sk, const u64 seq, 136extern void dccp_send_sync(struct sock *sk, const u64 seq,
135 const enum dccp_pkt_type pkt_type); 137 const enum dccp_pkt_type pkt_type);
136 138