dcb: unlock on error in dcbnl_ieee_get()

There is a "goto nla_put_failure" hidden inside the NLA_PUT() macro, but
we're holding the dcb_lock so we need to unlock first.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 8 insertions, 3 deletions

diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c
index 9399af565715..4323bd441f0f 100644
--- a/net/dcb/dcbnl.c
+++ b/net/dcb/dcbnl.c
@@ -1264,9 +1264,14 @@ static int dcbnl_ieee_get(struct net_device *netdev, struct nlattr **tb,
 
         spin_lock(&dcb_lock);
         list_for_each_entry(itr, &dcb_app_list, list) {
-                if (strncmp(itr->name, netdev->name, IFNAMSIZ) == 0)
-                        NLA_PUT(skb, DCB_ATTR_IEEE_APP,
-                                sizeof(itr->app), &itr->app);
+                if (strncmp(itr->name, netdev->name, IFNAMSIZ) == 0) {
+                        err = nla_put(skb, DCB_ATTR_IEEE_APP, sizeof(itr->app),
+                                         &itr->app);
+                        if (err) {
+                                spin_unlock(&dcb_lock);
+                                goto nla_put_failure;
+                        }
+                }
         }
         spin_unlock(&dcb_lock);
         nla_nest_end(skb, app);