aboutsummaryrefslogtreecommitdiffstats
path: root/net/core
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2008-07-15 06:03:33 -0400
committerDavid S. Miller <davem@davemloft.net>2008-07-17 22:21:10 -0400
commiteae792b722fef08dcf3aee88266ee7def9710757 (patch)
treea864c90974a8e998d56ee9f04801eb3f81a6bacf /net/core
parente3c50d5d25ac09efd9acbe2b2a3e365466de84ed (diff)
netdev: Add netdev->select_queue() method.
Devices or device layers can set this to control the queue selection performed by dev_pick_tx(). This function runs under RCU protection, which allows overriding functions to have some way of synchronizing with things like dynamic ->real_num_tx_queues adjustments. This makes the spinlock prefetch in dev_queue_xmit() a little bit less effective, but that's the price right now for correctness. Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
-rw-r--r--net/core/dev.c9
1 files changed, 6 insertions, 3 deletions
diff --git a/net/core/dev.c b/net/core/dev.c
index f027a1ac4fbb..7ca9564d2f44 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1670,6 +1670,9 @@ static struct netdev_queue *dev_pick_tx(struct net_device *dev,
1670{ 1670{
1671 u16 queue_index = 0; 1671 u16 queue_index = 0;
1672 1672
1673 if (dev->select_queue)
1674 queue_index = dev->select_queue(dev, skb);
1675
1673 skb_set_queue_mapping(skb, queue_index); 1676 skb_set_queue_mapping(skb, queue_index);
1674 return netdev_get_tx_queue(dev, queue_index); 1677 return netdev_get_tx_queue(dev, queue_index);
1675} 1678}
@@ -1710,14 +1713,14 @@ int dev_queue_xmit(struct sk_buff *skb)
1710 } 1713 }
1711 1714
1712gso: 1715gso:
1713 txq = dev_pick_tx(dev, skb);
1714 spin_lock_prefetch(&txq->lock);
1715
1716 /* Disable soft irqs for various locks below. Also 1716 /* Disable soft irqs for various locks below. Also
1717 * stops preemption for RCU. 1717 * stops preemption for RCU.
1718 */ 1718 */
1719 rcu_read_lock_bh(); 1719 rcu_read_lock_bh();
1720 1720
1721 txq = dev_pick_tx(dev, skb);
1722 spin_lock_prefetch(&txq->lock);
1723
1721 /* Updates of qdisc are serialized by queue->lock. 1724 /* Updates of qdisc are serialized by queue->lock.
1722 * The struct Qdisc which is pointed to by qdisc is now a 1725 * The struct Qdisc which is pointed to by qdisc is now a
1723 * rcu structure - it may be accessed without acquiring 1726 * rcu structure - it may be accessed without acquiring