aboutsummaryrefslogtreecommitdiffstats
path: root/net/core
diff options
context:
space:
mode:
authorNeil Horman <nhorman@tuxdriver.com>2009-03-11 05:49:55 -0400
committerDavid S. Miller <davem@davemloft.net>2009-03-13 15:09:28 -0400
commitead2ceb0ec9f85cff19c43b5cdb2f8a054484431 (patch)
tree258874b824bf241698d943daa9298bb18955e451 /net/core
parent4893d39e865b2897bf9fcd329697d37032d853a1 (diff)
Network Drop Monitor: Adding kfree_skb_clean for non-drops and modifying end-of-line points for skbs
Signed-off-by: Neil Horman <nhorman@tuxdriver.com> include/linux/skbuff.h | 4 +++- net/core/datagram.c | 2 +- net/core/skbuff.c | 22 ++++++++++++++++++++++ net/ipv4/arp.c | 2 +- net/ipv4/udp.c | 2 +- net/packet/af_packet.c | 2 +- 6 files changed, 29 insertions(+), 5 deletions(-) Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
-rw-r--r--net/core/datagram.c2
-rw-r--r--net/core/skbuff.c22
2 files changed, 23 insertions, 1 deletions
diff --git a/net/core/datagram.c b/net/core/datagram.c
index 5e2ac0c4b07c..d0de644b378d 100644
--- a/net/core/datagram.c
+++ b/net/core/datagram.c
@@ -208,7 +208,7 @@ struct sk_buff *skb_recv_datagram(struct sock *sk, unsigned flags,
208 208
209void skb_free_datagram(struct sock *sk, struct sk_buff *skb) 209void skb_free_datagram(struct sock *sk, struct sk_buff *skb)
210{ 210{
211 kfree_skb(skb); 211 consume_skb(skb);
212 sk_mem_reclaim_partial(sk); 212 sk_mem_reclaim_partial(sk);
213} 213}
214 214
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index e5e2111a397d..6acbf9e79eb1 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -65,6 +65,7 @@
65 65
66#include <asm/uaccess.h> 66#include <asm/uaccess.h>
67#include <asm/system.h> 67#include <asm/system.h>
68#include <trace/skb.h>
68 69
69#include "kmap_skb.h" 70#include "kmap_skb.h"
70 71
@@ -442,11 +443,32 @@ void kfree_skb(struct sk_buff *skb)
442 smp_rmb(); 443 smp_rmb();
443 else if (likely(!atomic_dec_and_test(&skb->users))) 444 else if (likely(!atomic_dec_and_test(&skb->users)))
444 return; 445 return;
446 trace_kfree_skb(skb, __builtin_return_address(0));
445 __kfree_skb(skb); 447 __kfree_skb(skb);
446} 448}
447EXPORT_SYMBOL(kfree_skb); 449EXPORT_SYMBOL(kfree_skb);
448 450
449/** 451/**
452 * consume_skb - free an skbuff
453 * @skb: buffer to free
454 *
455 * Drop a ref to the buffer and free it if the usage count has hit zero
456 * Functions identically to kfree_skb, but kfree_skb assumes that the frame
457 * is being dropped after a failure and notes that
458 */
459void consume_skb(struct sk_buff *skb)
460{
461 if (unlikely(!skb))
462 return;
463 if (likely(atomic_read(&skb->users) == 1))
464 smp_rmb();
465 else if (likely(!atomic_dec_and_test(&skb->users)))
466 return;
467 __kfree_skb(skb);
468}
469EXPORT_SYMBOL(consume_skb);
470
471/**
450 * skb_recycle_check - check if skb can be reused for receive 472 * skb_recycle_check - check if skb can be reused for receive
451 * @skb: buffer 473 * @skb: buffer
452 * @skb_size: minimum receive buffer size 474 * @skb_size: minimum receive buffer size