diff options
author | David S. Miller <davem@davemloft.net> | 2009-01-05 19:01:51 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-01-05 19:01:51 -0500 |
commit | c276e098d3ee33059b4a1c747354226cec58487c (patch) | |
tree | df833d2e6719dd83f219a846520a581b152d5332 /net/core | |
parent | 7945cc6464a4db0caf6dfacdfe05806051c4cb7b (diff) |
Revert "net: Fix for initial link state in 2.6.28"
This reverts commit 22604c866889c4b2e12b73cbf1683bda1b72a313.
We can't fix this issue in this way, because we now can try
to take the dev_base_lock rwlock as a writer in software interrupt
context and that is not allowed without major surgery elsewhere.
This initial link state problem needs to be solved in some other
way.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
-rw-r--r-- | net/core/link_watch.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/net/core/link_watch.c b/net/core/link_watch.c index 1e401e12dc72..bf8f7af699d7 100644 --- a/net/core/link_watch.c +++ b/net/core/link_watch.c | |||
@@ -178,6 +178,7 @@ static void __linkwatch_run_queue(int urgent_only) | |||
178 | */ | 178 | */ |
179 | clear_bit(__LINK_STATE_LINKWATCH_PENDING, &dev->state); | 179 | clear_bit(__LINK_STATE_LINKWATCH_PENDING, &dev->state); |
180 | 180 | ||
181 | rfc2863_policy(dev); | ||
181 | if (dev->flags & IFF_UP) { | 182 | if (dev->flags & IFF_UP) { |
182 | if (netif_carrier_ok(dev)) | 183 | if (netif_carrier_ok(dev)) |
183 | dev_activate(dev); | 184 | dev_activate(dev); |
@@ -214,12 +215,6 @@ void linkwatch_fire_event(struct net_device *dev) | |||
214 | { | 215 | { |
215 | bool urgent = linkwatch_urgent_event(dev); | 216 | bool urgent = linkwatch_urgent_event(dev); |
216 | 217 | ||
217 | rfc2863_policy(dev); | ||
218 | |||
219 | /* Some drivers call netif_carrier_off early */ | ||
220 | if (dev->reg_state == NETREG_UNINITIALIZED) | ||
221 | return; | ||
222 | |||
223 | if (!test_and_set_bit(__LINK_STATE_LINKWATCH_PENDING, &dev->state)) { | 218 | if (!test_and_set_bit(__LINK_STATE_LINKWATCH_PENDING, &dev->state)) { |
224 | dev_hold(dev); | 219 | dev_hold(dev); |
225 | 220 | ||