aboutsummaryrefslogtreecommitdiffstats
path: root/net/core
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2008-08-18 00:51:03 -0400
committerDavid S. Miller <davem@davemloft.net>2008-08-18 00:51:03 -0400
commita9312ae89324438b0edc554eb36c3ec6bf927d04 (patch)
tree8a440aa75a9ac5aba1447082ec43ed48951aa121 /net/core
parent08013fa353fdcfc0a03cae805393abfc56722387 (diff)
pkt_sched: Add 'deactivated' state.
This new state lets dev_deactivate() mark a qdisc as having been deactivated. dev_queue_xmit() and ing_filter() check for this bit and do not try to process the qdisc if the bit is set. dev_deactivate() polls the qdisc after setting the bit, waiting for both __QDISC_STATE_RUNNING and __QDISC_STATE_SCHED to clear. This isn't perfect yet, but subsequent changesets will make it so. This part is just one piece of the puzzle. Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
-rw-r--r--net/core/dev.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/net/core/dev.c b/net/core/dev.c
index 600bb23c4c2e..d9e31f63aded 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1800,6 +1800,12 @@ gso:
1800 1800
1801 spin_lock(root_lock); 1801 spin_lock(root_lock);
1802 1802
1803 if (unlikely(test_bit(__QDISC_STATE_DEACTIVATED, &q->state))) {
1804 spin_unlock(root_lock);
1805 rc = NET_XMIT_DROP;
1806 goto out_kfree_skb;
1807 }
1808
1803 rc = qdisc_enqueue_root(skb, q); 1809 rc = qdisc_enqueue_root(skb, q);
1804 qdisc_run(q); 1810 qdisc_run(q);
1805 1811
@@ -2084,7 +2090,8 @@ static int ing_filter(struct sk_buff *skb)
2084 q = rxq->qdisc; 2090 q = rxq->qdisc;
2085 if (q != &noop_qdisc) { 2091 if (q != &noop_qdisc) {
2086 spin_lock(qdisc_lock(q)); 2092 spin_lock(qdisc_lock(q));
2087 result = qdisc_enqueue_root(skb, q); 2093 if (likely(!test_bit(__QDISC_STATE_DEACTIVATED, &q->state)))
2094 result = qdisc_enqueue_root(skb, q);
2088 spin_unlock(qdisc_lock(q)); 2095 spin_unlock(qdisc_lock(q));
2089 } 2096 }
2090 2097