diff options
author | Eric W. Biederman <ebiederm@xmission.com> | 2010-02-13 22:27:03 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-02-16 18:55:18 -0500 |
commit | 54716e3beb0ab20c49471348dfe399a71bfc8fd3 (patch) | |
tree | 216e2b70e58032217082da224c397db46c13429c /net/core | |
parent | 02291680ffba92e5b5865bc0c5e7d1f3056b80ec (diff) |
net neigh: Decouple per interface neighbour table controls from binary sysctls
Stop computing the number of neighbour table settings we have by
counting the number of binary sysctls. This behaviour was silly
and meant that we could not add another neighbour table setting
without also adding another binary sysctl.
Don't pass the binary sysctl path for neighour table entries
into neigh_sysctl_register. These parameters are no longer
used and so are just dead code.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
-rw-r--r-- | net/core/neighbour.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/net/core/neighbour.c b/net/core/neighbour.c index f2efd72da799..d102f6d9abdc 100644 --- a/net/core/neighbour.c +++ b/net/core/neighbour.c | |||
@@ -2556,9 +2556,11 @@ EXPORT_SYMBOL(neigh_app_ns); | |||
2556 | 2556 | ||
2557 | #ifdef CONFIG_SYSCTL | 2557 | #ifdef CONFIG_SYSCTL |
2558 | 2558 | ||
2559 | #define NEIGH_VARS_MAX 19 | ||
2560 | |||
2559 | static struct neigh_sysctl_table { | 2561 | static struct neigh_sysctl_table { |
2560 | struct ctl_table_header *sysctl_header; | 2562 | struct ctl_table_header *sysctl_header; |
2561 | struct ctl_table neigh_vars[__NET_NEIGH_MAX]; | 2563 | struct ctl_table neigh_vars[NEIGH_VARS_MAX]; |
2562 | char *dev_name; | 2564 | char *dev_name; |
2563 | } neigh_sysctl_template __read_mostly = { | 2565 | } neigh_sysctl_template __read_mostly = { |
2564 | .neigh_vars = { | 2566 | .neigh_vars = { |
@@ -2675,8 +2677,7 @@ static struct neigh_sysctl_table { | |||
2675 | }; | 2677 | }; |
2676 | 2678 | ||
2677 | int neigh_sysctl_register(struct net_device *dev, struct neigh_parms *p, | 2679 | int neigh_sysctl_register(struct net_device *dev, struct neigh_parms *p, |
2678 | int p_id, int pdev_id, char *p_name, | 2680 | char *p_name, proc_handler *handler) |
2679 | proc_handler *handler) | ||
2680 | { | 2681 | { |
2681 | struct neigh_sysctl_table *t; | 2682 | struct neigh_sysctl_table *t; |
2682 | const char *dev_name_source = NULL; | 2683 | const char *dev_name_source = NULL; |