diff options
author | Michał Mirosław <mirq-linux@rere.qmqm.pl> | 2011-02-22 11:52:28 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2011-02-23 17:23:31 -0500 |
commit | 14d1232f490c1c696582909fb3b69e67a8d38a34 (patch) | |
tree | 72e8c7ddd266fba48d1b0aa5b537393b73b7b293 /net/core | |
parent | 8e9b59b219e520cfc2f80af471c6b0e67ad9dd75 (diff) |
net: avoid initial "Features changed" message
Avoid "Features changed" message and ndo_set_features call on device
registration caused by automatic enabling of GSO and GRO. Driver should
have enabled hardware offloads it set in features, so the ndo_set_features()
is not needed at registration time.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
-rw-r--r-- | net/core/dev.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index 77e5edb724f4..69a3c0817d6f 100644 --- a/net/core/dev.c +++ b/net/core/dev.c | |||
@@ -5476,12 +5476,14 @@ int register_netdevice(struct net_device *dev) | |||
5476 | * software offloads (GSO and GRO). | 5476 | * software offloads (GSO and GRO). |
5477 | */ | 5477 | */ |
5478 | dev->hw_features |= NETIF_F_SOFT_FEATURES; | 5478 | dev->hw_features |= NETIF_F_SOFT_FEATURES; |
5479 | dev->wanted_features = (dev->features & dev->hw_features) | 5479 | dev->features |= NETIF_F_SOFT_FEATURES; |
5480 | | NETIF_F_SOFT_FEATURES; | 5480 | dev->wanted_features = dev->features & dev->hw_features; |
5481 | 5481 | ||
5482 | /* Avoid warning from netdev_fix_features() for GSO without SG */ | 5482 | /* Avoid warning from netdev_fix_features() for GSO without SG */ |
5483 | if (!(dev->wanted_features & NETIF_F_SG)) | 5483 | if (!(dev->wanted_features & NETIF_F_SG)) { |
5484 | dev->wanted_features &= ~NETIF_F_GSO; | 5484 | dev->wanted_features &= ~NETIF_F_GSO; |
5485 | dev->features &= ~NETIF_F_GSO; | ||
5486 | } | ||
5485 | 5487 | ||
5486 | /* Enable GRO and NETIF_F_HIGHDMA for vlans by default, | 5488 | /* Enable GRO and NETIF_F_HIGHDMA for vlans by default, |
5487 | * vlan_dev_init() will do the dev->features check, so these features | 5489 | * vlan_dev_init() will do the dev->features check, so these features |