aboutsummaryrefslogtreecommitdiffstats
path: root/net/core/ethtool.c
diff options
context:
space:
mode:
authorstephen hemminger <shemminger@vyatta.com>2010-08-23 06:24:18 -0400
committerDavid S. Miller <davem@davemloft.net>2010-08-23 23:43:16 -0400
commit0fdc100bdc4b7ab61ed632962c76dfe539047296 (patch)
tree354e79b15b101a2ace627ce08779e4ef40c1e477 /net/core/ethtool.c
parentafdcba371f9748ac91608bb6c57f170aab7085b4 (diff)
ethtool: allow non-netadmin to query settings
The SNMP daemon uses ethtool to determine the speed of network interfaces. This fails on Debian (and probably elsewhere) because for security SNMP daemon runs as non-root user (snmp). Note: A similar patch was rejected previously because of a concern about the possibility that on some hardware querying the ethtool settings requires access to the PHY and could slow the machine down. But the security risk of requiring SNMP daemon (and related services) to run as root far out weighs the risk of denial-of-service. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/ethtool.c')
-rw-r--r--net/core/ethtool.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index d2c4da5a6a4f..970eb9817bbc 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -1423,6 +1423,7 @@ int dev_ethtool(struct net *net, struct ifreq *ifr)
1423 1423
1424 /* Allow some commands to be done by anyone */ 1424 /* Allow some commands to be done by anyone */
1425 switch (ethcmd) { 1425 switch (ethcmd) {
1426 case ETHTOOL_GSET:
1426 case ETHTOOL_GDRVINFO: 1427 case ETHTOOL_GDRVINFO:
1427 case ETHTOOL_GMSGLVL: 1428 case ETHTOOL_GMSGLVL:
1428 case ETHTOOL_GCOALESCE: 1429 case ETHTOOL_GCOALESCE: