diff options
author | Joe Perches <joe@perches.com> | 2010-09-05 17:31:11 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-09-06 21:48:43 -0400 |
commit | b31fa5bad576cd8180a5ad70c648333b44320d44 (patch) | |
tree | b31239e8828e7e5b36ef85a0715ababc4f556e42 /net/caif/cfsrvl.c | |
parent | a0ece28539d49c9bdcc6da0bbb26771dceb57581 (diff) |
net/caif: Use pr_fmt
This patch standardizes caif message logging prefixes.
Add #define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__
Add missing "\n"s to some logging messages
Convert pr_warning to pr_warn
This changes the logging message prefix from CAIF: to caif:
for all uses but caif_socket.c and chnl_net.c. Those now use
their filename without extension.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/caif/cfsrvl.c')
-rw-r--r-- | net/caif/cfsrvl.c | 17 |
1 files changed, 7 insertions, 10 deletions
diff --git a/net/caif/cfsrvl.c b/net/caif/cfsrvl.c index f40939a91211..ab5e542526bf 100644 --- a/net/caif/cfsrvl.c +++ b/net/caif/cfsrvl.c | |||
@@ -4,6 +4,8 @@ | |||
4 | * License terms: GNU General Public License (GPL) version 2 | 4 | * License terms: GNU General Public License (GPL) version 2 |
5 | */ | 5 | */ |
6 | 6 | ||
7 | #define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__ | ||
8 | |||
7 | #include <linux/kernel.h> | 9 | #include <linux/kernel.h> |
8 | #include <linux/types.h> | 10 | #include <linux/types.h> |
9 | #include <linux/errno.h> | 11 | #include <linux/errno.h> |
@@ -79,8 +81,7 @@ static void cfservl_ctrlcmd(struct cflayer *layr, enum caif_ctrlcmd ctrl, | |||
79 | layr->up->ctrlcmd(layr->up, ctrl, phyid); | 81 | layr->up->ctrlcmd(layr->up, ctrl, phyid); |
80 | break; | 82 | break; |
81 | default: | 83 | default: |
82 | pr_warning("CAIF: %s(): " | 84 | pr_warn("Unexpected ctrl in cfsrvl (%d)\n", ctrl); |
83 | "Unexpected ctrl in cfsrvl (%d)\n", __func__, ctrl); | ||
84 | /* We have both modem and phy flow on, send flow on */ | 85 | /* We have both modem and phy flow on, send flow on */ |
85 | layr->up->ctrlcmd(layr->up, ctrl, phyid); | 86 | layr->up->ctrlcmd(layr->up, ctrl, phyid); |
86 | service->phy_flow_on = true; | 87 | service->phy_flow_on = true; |
@@ -107,14 +108,12 @@ static int cfservl_modemcmd(struct cflayer *layr, enum caif_modemcmd ctrl) | |||
107 | u8 flow_on = SRVL_FLOW_ON; | 108 | u8 flow_on = SRVL_FLOW_ON; |
108 | pkt = cfpkt_create(SRVL_CTRL_PKT_SIZE); | 109 | pkt = cfpkt_create(SRVL_CTRL_PKT_SIZE); |
109 | if (!pkt) { | 110 | if (!pkt) { |
110 | pr_warning("CAIF: %s(): Out of memory\n", | 111 | pr_warn("Out of memory\n"); |
111 | __func__); | ||
112 | return -ENOMEM; | 112 | return -ENOMEM; |
113 | } | 113 | } |
114 | 114 | ||
115 | if (cfpkt_add_head(pkt, &flow_on, 1) < 0) { | 115 | if (cfpkt_add_head(pkt, &flow_on, 1) < 0) { |
116 | pr_err("CAIF: %s(): Packet is erroneous!\n", | 116 | pr_err("Packet is erroneous!\n"); |
117 | __func__); | ||
118 | cfpkt_destroy(pkt); | 117 | cfpkt_destroy(pkt); |
119 | return -EPROTO; | 118 | return -EPROTO; |
120 | } | 119 | } |
@@ -131,14 +130,12 @@ static int cfservl_modemcmd(struct cflayer *layr, enum caif_modemcmd ctrl) | |||
131 | u8 flow_off = SRVL_FLOW_OFF; | 130 | u8 flow_off = SRVL_FLOW_OFF; |
132 | pkt = cfpkt_create(SRVL_CTRL_PKT_SIZE); | 131 | pkt = cfpkt_create(SRVL_CTRL_PKT_SIZE); |
133 | if (!pkt) { | 132 | if (!pkt) { |
134 | pr_warning("CAIF: %s(): Out of memory\n", | 133 | pr_warn("Out of memory\n"); |
135 | __func__); | ||
136 | return -ENOMEM; | 134 | return -ENOMEM; |
137 | } | 135 | } |
138 | 136 | ||
139 | if (cfpkt_add_head(pkt, &flow_off, 1) < 0) { | 137 | if (cfpkt_add_head(pkt, &flow_off, 1) < 0) { |
140 | pr_err("CAIF: %s(): Packet is erroneous!\n", | 138 | pr_err("Packet is erroneous!\n"); |
141 | __func__); | ||
142 | cfpkt_destroy(pkt); | 139 | cfpkt_destroy(pkt); |
143 | return -EPROTO; | 140 | return -EPROTO; |
144 | } | 141 | } |