diff options
author | Sjur Brændeland <sjur.brandeland@stericsson.com> | 2012-07-15 06:10:14 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-07-17 02:06:20 -0400 |
commit | 96f80d123eff05c3cd4701463786b87952a6c3ac (patch) | |
tree | 92503024242249886dc4533b5f9aaeb081c2b296 /net/caif/caif_dev.c | |
parent | ef209f15980360f6945873df3cd710c5f62f2a3e (diff) |
caif: Fix access to freed pernet memory
unregister_netdevice_notifier() must be called before
unregister_pernet_subsys() to avoid accessing already freed
pernet memory. This fixes the following oops when doing rmmod:
Call Trace:
[<ffffffffa0f802bd>] caif_device_notify+0x4d/0x5a0 [caif]
[<ffffffff81552ba9>] unregister_netdevice_notifier+0xb9/0x100
[<ffffffffa0f86dcc>] caif_device_exit+0x1c/0x250 [caif]
[<ffffffff810e7734>] sys_delete_module+0x1a4/0x300
[<ffffffff810da82d>] ? trace_hardirqs_on_caller+0x15d/0x1e0
[<ffffffff813517de>] ? trace_hardirqs_on_thunk+0x3a/0x3
[<ffffffff81696bad>] system_call_fastpath+0x1a/0x1f
RIP
[<ffffffffa0f7f561>] caif_get+0x51/0xb0 [caif]
Signed-off-by: Sjur Brændeland <sjur.brandeland@stericsson.com>
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/caif/caif_dev.c')
-rw-r--r-- | net/caif/caif_dev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/caif/caif_dev.c b/net/caif/caif_dev.c index 554b31289607..8c83c175b03a 100644 --- a/net/caif/caif_dev.c +++ b/net/caif/caif_dev.c | |||
@@ -561,9 +561,9 @@ static int __init caif_device_init(void) | |||
561 | 561 | ||
562 | static void __exit caif_device_exit(void) | 562 | static void __exit caif_device_exit(void) |
563 | { | 563 | { |
564 | unregister_pernet_subsys(&caif_net_ops); | ||
565 | unregister_netdevice_notifier(&caif_device_notifier); | 564 | unregister_netdevice_notifier(&caif_device_notifier); |
566 | dev_remove_pack(&caif_packet_type); | 565 | dev_remove_pack(&caif_packet_type); |
566 | unregister_pernet_subsys(&caif_net_ops); | ||
567 | } | 567 | } |
568 | 568 | ||
569 | module_init(caif_device_init); | 569 | module_init(caif_device_init); |