aboutsummaryrefslogtreecommitdiffstats
path: root/net/bridge
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2014-02-23 03:05:25 -0500
committerDavid S. Miller <davem@davemloft.net>2014-02-24 19:16:43 -0500
commite5a727f6632654098fa4e87d8551a5873e8f658a (patch)
tree1857fd4823e2f393b400550039018563bf7f9591 /net/bridge
parente8b39015b591f359d464d026170dcf76f7ed5b8e (diff)
bridge: Use ether_addr_copy and ETH_ALEN
Convert the more obvious uses of memcpy to ether_addr_copy. There are still uses of memcpy that could be converted but these addresses are __aligned(2). Convert a couple uses of 6 in gr_private.h to ETH_ALEN. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/bridge')
-rw-r--r--net/bridge/br_device.c2
-rw-r--r--net/bridge/br_multicast.c4
-rw-r--r--net/bridge/br_private.h4
3 files changed, 5 insertions, 5 deletions
diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c
index bf34451743a1..b063050b63e2 100644
--- a/net/bridge/br_device.c
+++ b/net/bridge/br_device.c
@@ -367,7 +367,7 @@ void br_dev_setup(struct net_device *dev)
367 br->bridge_id.prio[0] = 0x80; 367 br->bridge_id.prio[0] = 0x80;
368 br->bridge_id.prio[1] = 0x00; 368 br->bridge_id.prio[1] = 0x00;
369 369
370 memcpy(br->group_addr, eth_reserved_addr_base, ETH_ALEN); 370 ether_addr_copy(br->group_addr, eth_reserved_addr_base);
371 371
372 br->stp_enabled = BR_NO_STP; 372 br->stp_enabled = BR_NO_STP;
373 br->group_fwd_mask = BR_GROUPFWD_DEFAULT; 373 br->group_fwd_mask = BR_GROUPFWD_DEFAULT;
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index ef66365b7354..c97c3c8ccdfb 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -363,7 +363,7 @@ static struct sk_buff *br_ip4_multicast_alloc_query(struct net_bridge *br,
363 skb_reset_mac_header(skb); 363 skb_reset_mac_header(skb);
364 eth = eth_hdr(skb); 364 eth = eth_hdr(skb);
365 365
366 memcpy(eth->h_source, br->dev->dev_addr, ETH_ALEN); 366 ether_addr_copy(eth->h_source, br->dev->dev_addr);
367 eth->h_dest[0] = 1; 367 eth->h_dest[0] = 1;
368 eth->h_dest[1] = 0; 368 eth->h_dest[1] = 0;
369 eth->h_dest[2] = 0x5e; 369 eth->h_dest[2] = 0x5e;
@@ -433,7 +433,7 @@ static struct sk_buff *br_ip6_multicast_alloc_query(struct net_bridge *br,
433 skb_reset_mac_header(skb); 433 skb_reset_mac_header(skb);
434 eth = eth_hdr(skb); 434 eth = eth_hdr(skb);
435 435
436 memcpy(eth->h_source, br->dev->dev_addr, ETH_ALEN); 436 ether_addr_copy(eth->h_source, br->dev->dev_addr);
437 eth->h_proto = htons(ETH_P_IPV6); 437 eth->h_proto = htons(ETH_P_IPV6);
438 skb_put(skb, sizeof(*eth)); 438 skb_put(skb, sizeof(*eth));
439 439
diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
index 3ba11bc99b65..e1ca1dc916a4 100644
--- a/net/bridge/br_private.h
+++ b/net/bridge/br_private.h
@@ -46,12 +46,12 @@ typedef __u16 port_id;
46struct bridge_id 46struct bridge_id
47{ 47{
48 unsigned char prio[2]; 48 unsigned char prio[2];
49 unsigned char addr[6]; 49 unsigned char addr[ETH_ALEN];
50}; 50};
51 51
52struct mac_addr 52struct mac_addr
53{ 53{
54 unsigned char addr[6]; 54 unsigned char addr[ETH_ALEN];
55}; 55};
56 56
57struct br_ip 57struct br_ip