diff options
author | Wang Chen <wangchen@cn.fujitsu.com> | 2008-07-14 23:51:36 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-07-14 23:51:36 -0400 |
commit | 7e1a1ac1fbaa88fe254400b7f30b775502932ad3 (patch) | |
tree | 5084fc1e90687cdec4ad62cd1ae81b75e6efe765 /net/bridge | |
parent | 2aeb0b88b3c7a0e3bef55e7ff0efffd5d971aa57 (diff) |
bonding: Check return of dev_set_promiscuity/allmulti
dev_set_promiscuity/allmulti might overflow.
Commit: "netdevice: Fix promiscuity and allmulti overflow" in net-next makes
dev_set_promiscuity/allmulti return error number if overflow happened.
In bond_alb and bond_main, we check all positive increment for promiscuity
and allmulti to get error return.
But there are still two problems left.
1. Some code path has no mechanism to signal errors upstream.
2. If there are multi slaves, it's hard to tell which slaves increment
promisc/allmulti successfully and which failed.
So I left these problems to be FIXME.
Fortunately, the overflow is very rare case.
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/bridge')
0 files changed, 0 insertions, 0 deletions