diff options
author | Gao feng <gaofeng@cn.fujitsu.com> | 2013-02-18 11:59:10 -0500 |
---|---|---|
committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2013-03-15 06:56:09 -0400 |
commit | fa900b9cf5a574cc66cc9b50749999d8b6de6ed8 (patch) | |
tree | 702cb2d8fbff1fd0fc2d2913e2c9cd624f5586b7 /net/bridge | |
parent | d00bd3d4fba89e6f7ffb94a5f9274cce49dc84a7 (diff) |
netfilter: ebt_ulog: remove unnecessary spin lock protection
No need for spinlock to protect the netlink skb in the
ebt_ulog_fini path. We are sure there is noone using it
at that stage.
Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net/bridge')
-rw-r--r-- | net/bridge/netfilter/ebt_ulog.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/bridge/netfilter/ebt_ulog.c b/net/bridge/netfilter/ebt_ulog.c index 3bf43f7bb9d4..442b0321acb9 100644 --- a/net/bridge/netfilter/ebt_ulog.c +++ b/net/bridge/netfilter/ebt_ulog.c | |||
@@ -319,12 +319,11 @@ static void __exit ebt_ulog_fini(void) | |||
319 | for (i = 0; i < EBT_ULOG_MAXNLGROUPS; i++) { | 319 | for (i = 0; i < EBT_ULOG_MAXNLGROUPS; i++) { |
320 | ub = &ulog_buffers[i]; | 320 | ub = &ulog_buffers[i]; |
321 | del_timer(&ub->timer); | 321 | del_timer(&ub->timer); |
322 | spin_lock_bh(&ub->lock); | 322 | |
323 | if (ub->skb) { | 323 | if (ub->skb) { |
324 | kfree_skb(ub->skb); | 324 | kfree_skb(ub->skb); |
325 | ub->skb = NULL; | 325 | ub->skb = NULL; |
326 | } | 326 | } |
327 | spin_unlock_bh(&ub->lock); | ||
328 | } | 327 | } |
329 | netlink_kernel_release(ebtulognl); | 328 | netlink_kernel_release(ebtulognl); |
330 | } | 329 | } |