diff options
author | Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp> | 2013-11-13 03:26:13 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-11-14 16:16:34 -0500 |
commit | dbbaf949bcd0ffb8b17cf0438060d55d6cfb8a4b (patch) | |
tree | 3d2e06f417cd6e2e118516f2a6867eaf358a7a73 /net/bridge/br_vlan.c | |
parent | 192368372d3d29fe04f6ed2a5255ae2d1b58cf76 (diff) |
bridge: Call vlan_vid_del for all vids at nbp_vlan_flush
We should call vlan_vid_del for all vids at nbp_vlan_flush to prevent
vid_info->refcount from being leaked when detaching a bridge port.
Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/bridge/br_vlan.c')
-rw-r--r-- | net/bridge/br_vlan.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/net/bridge/br_vlan.c b/net/bridge/br_vlan.c index 57074be62fcb..af5ebd18d705 100644 --- a/net/bridge/br_vlan.c +++ b/net/bridge/br_vlan.c | |||
@@ -390,6 +390,7 @@ int nbp_vlan_delete(struct net_bridge_port *port, u16 vid) | |||
390 | void nbp_vlan_flush(struct net_bridge_port *port) | 390 | void nbp_vlan_flush(struct net_bridge_port *port) |
391 | { | 391 | { |
392 | struct net_port_vlans *pv; | 392 | struct net_port_vlans *pv; |
393 | u16 vid; | ||
393 | 394 | ||
394 | ASSERT_RTNL(); | 395 | ASSERT_RTNL(); |
395 | 396 | ||
@@ -397,6 +398,9 @@ void nbp_vlan_flush(struct net_bridge_port *port) | |||
397 | if (!pv) | 398 | if (!pv) |
398 | return; | 399 | return; |
399 | 400 | ||
401 | for_each_set_bit(vid, pv->vlan_bitmap, VLAN_N_VID) | ||
402 | vlan_vid_del(port->dev, htons(ETH_P_8021Q), vid); | ||
403 | |||
400 | __vlan_flush(pv); | 404 | __vlan_flush(pv); |
401 | } | 405 | } |
402 | 406 | ||