diff options
author | Joe Perches <joe@perches.com> | 2012-05-08 14:56:49 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-05-09 20:49:17 -0400 |
commit | 9a7b6ef9b9938a1f5cb91ccc0b713b9443edc79f (patch) | |
tree | 9fcdd72bb2adb4e481bf30aa0143d65627ebd637 /net/bridge/br_input.c | |
parent | 171fe5ef140571c7465e625e9cd9fdf3340ad20e (diff) |
bridge: Convert compare_ether_addr to ether_addr_equal
Use the new bool function ether_addr_equal to add
some clarity and reduce the likelihood for misuse
of compare_ether_addr for sorting.
Done via cocci script:
$ cat compare_ether_addr.cocci
@@
expression a,b;
@@
- !compare_ether_addr(a, b)
+ ether_addr_equal(a, b)
@@
expression a,b;
@@
- compare_ether_addr(a, b)
+ !ether_addr_equal(a, b)
@@
expression a,b;
@@
- !ether_addr_equal(a, b) == 0
+ ether_addr_equal(a, b)
@@
expression a,b;
@@
- !ether_addr_equal(a, b) != 0
+ !ether_addr_equal(a, b)
@@
expression a,b;
@@
- ether_addr_equal(a, b) == 0
+ !ether_addr_equal(a, b)
@@
expression a,b;
@@
- ether_addr_equal(a, b) != 0
+ ether_addr_equal(a, b)
@@
expression a,b;
@@
- !!ether_addr_equal(a, b)
+ ether_addr_equal(a, b)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/bridge/br_input.c')
-rw-r--r-- | net/bridge/br_input.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c index 5a31731be4d0..76f15fda0212 100644 --- a/net/bridge/br_input.c +++ b/net/bridge/br_input.c | |||
@@ -216,7 +216,7 @@ forward: | |||
216 | } | 216 | } |
217 | /* fall through */ | 217 | /* fall through */ |
218 | case BR_STATE_LEARNING: | 218 | case BR_STATE_LEARNING: |
219 | if (!compare_ether_addr(p->br->dev->dev_addr, dest)) | 219 | if (ether_addr_equal(p->br->dev->dev_addr, dest)) |
220 | skb->pkt_type = PACKET_HOST; | 220 | skb->pkt_type = PACKET_HOST; |
221 | 221 | ||
222 | NF_HOOK(NFPROTO_BRIDGE, NF_BR_PRE_ROUTING, skb, skb->dev, NULL, | 222 | NF_HOOK(NFPROTO_BRIDGE, NF_BR_PRE_ROUTING, skb, skb->dev, NULL, |