Bluetooth: Fix mgmt_pin_code_reply return parameters

The command complete event for mgmt_pin_code_reply &
mgmt_pin_code_neg_reply should have the adapter index, Bluetooth address
as well as the status.

Signed-off-by: Johan Hedberg <johan.hedberg@nokia.com>
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>

1 files changed, 13 insertions, 10 deletions

diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index d1d9b8c3a1b0..0d3d613baac2 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -1558,17 +1558,18 @@ int mgmt_pin_code_request(u16 index, bdaddr_t *bdaddr)
 int mgmt_pin_code_reply_complete(u16 index, bdaddr_t *bdaddr, u8 status)
 {
         struct pending_cmd *cmd;
+        struct mgmt_rp_pin_code_reply rp;
         int err;
 
         cmd = mgmt_pending_find(MGMT_OP_PIN_CODE_REPLY, index);
         if (!cmd)
                 return -ENOENT;
 
-        if (status != 0)
-                err = cmd_status(cmd->sk, MGMT_OP_PIN_CODE_REPLY, status);
-        else
-                err = cmd_complete(cmd->sk, MGMT_OP_PIN_CODE_REPLY,
-                                                bdaddr, sizeof(*bdaddr));
+        put_unaligned_le16(index, &rp.index);
+        bacpy(&rp.bdaddr, bdaddr);
+        rp.status = status;
+
+        err = cmd_complete(cmd->sk, MGMT_OP_PIN_CODE_REPLY, &rp, sizeof(rp));
 
         list_del(&cmd->list);
         mgmt_pending_free(cmd);
@@ -1579,17 +1580,19 @@ int mgmt_pin_code_reply_complete(u16 index, bdaddr_t *bdaddr, u8 status)
 int mgmt_pin_code_neg_reply_complete(u16 index, bdaddr_t *bdaddr, u8 status)
 {
         struct pending_cmd *cmd;
+        struct mgmt_rp_pin_code_reply rp;
         int err;
 
         cmd = mgmt_pending_find(MGMT_OP_PIN_CODE_NEG_REPLY, index);
         if (!cmd)
                 return -ENOENT;
 
-        if (status != 0)
-                err = cmd_status(cmd->sk, MGMT_OP_PIN_CODE_NEG_REPLY, status);
-        else
-                err = cmd_complete(cmd->sk, MGMT_OP_PIN_CODE_NEG_REPLY,
-                                                bdaddr, sizeof(*bdaddr));
+        put_unaligned_le16(index, &rp.index);
+        bacpy(&rp.bdaddr, bdaddr);
+        rp.status = status;
+
+        err = cmd_complete(cmd->sk, MGMT_OP_PIN_CODE_NEG_REPLY,
+                                                        &rp, sizeof(rp));
 
         list_del(&cmd->list);
         mgmt_pending_free(cmd);