diff options
author | Gustavo F. Padovan <padovan@profusion.mobi> | 2010-09-03 17:29:46 -0400 |
---|---|---|
committer | Gustavo F. Padovan <padovan@profusion.mobi> | 2010-10-12 11:44:52 -0400 |
commit | d6b2eb2f893547d7488d31a7088d78dd77ab5995 (patch) | |
tree | fd632fa1316348a928bfc4dce7fbdb02b209467f /net/bluetooth/hci_sysfs.c | |
parent | cb810a189da312d4074cb3fc8b0267b7115e7be1 (diff) |
Bluetooth: make batostr() print in the right order
The Bluetooth core uses the the BD_ADDR in the opposite order from the
human readable order. So we are changing batostr() to print in the
correct order and then removing some baswap(), as they are not needed
anymore.
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
Diffstat (limited to 'net/bluetooth/hci_sysfs.c')
-rw-r--r-- | net/bluetooth/hci_sysfs.c | 17 |
1 files changed, 4 insertions, 13 deletions
diff --git a/net/bluetooth/hci_sysfs.c b/net/bluetooth/hci_sysfs.c index 1a9f0db027da..5fce3d6d07b4 100644 --- a/net/bluetooth/hci_sysfs.c +++ b/net/bluetooth/hci_sysfs.c | |||
@@ -37,9 +37,7 @@ static ssize_t show_link_type(struct device *dev, struct device_attribute *attr, | |||
37 | static ssize_t show_link_address(struct device *dev, struct device_attribute *attr, char *buf) | 37 | static ssize_t show_link_address(struct device *dev, struct device_attribute *attr, char *buf) |
38 | { | 38 | { |
39 | struct hci_conn *conn = dev_get_drvdata(dev); | 39 | struct hci_conn *conn = dev_get_drvdata(dev); |
40 | bdaddr_t bdaddr; | 40 | return sprintf(buf, "%s\n", batostr(&conn->dst)); |
41 | baswap(&bdaddr, &conn->dst); | ||
42 | return sprintf(buf, "%s\n", batostr(&bdaddr)); | ||
43 | } | 41 | } |
44 | 42 | ||
45 | static ssize_t show_link_features(struct device *dev, struct device_attribute *attr, char *buf) | 43 | static ssize_t show_link_features(struct device *dev, struct device_attribute *attr, char *buf) |
@@ -238,9 +236,7 @@ static ssize_t show_class(struct device *dev, struct device_attribute *attr, cha | |||
238 | static ssize_t show_address(struct device *dev, struct device_attribute *attr, char *buf) | 236 | static ssize_t show_address(struct device *dev, struct device_attribute *attr, char *buf) |
239 | { | 237 | { |
240 | struct hci_dev *hdev = dev_get_drvdata(dev); | 238 | struct hci_dev *hdev = dev_get_drvdata(dev); |
241 | bdaddr_t bdaddr; | 239 | return sprintf(buf, "%s\n", batostr(&hdev->bdaddr)); |
242 | baswap(&bdaddr, &hdev->bdaddr); | ||
243 | return sprintf(buf, "%s\n", batostr(&bdaddr)); | ||
244 | } | 240 | } |
245 | 241 | ||
246 | static ssize_t show_features(struct device *dev, struct device_attribute *attr, char *buf) | 242 | static ssize_t show_features(struct device *dev, struct device_attribute *attr, char *buf) |
@@ -408,10 +404,8 @@ static int inquiry_cache_show(struct seq_file *f, void *p) | |||
408 | 404 | ||
409 | for (e = cache->list; e; e = e->next) { | 405 | for (e = cache->list; e; e = e->next) { |
410 | struct inquiry_data *data = &e->data; | 406 | struct inquiry_data *data = &e->data; |
411 | bdaddr_t bdaddr; | ||
412 | baswap(&bdaddr, &data->bdaddr); | ||
413 | seq_printf(f, "%s %d %d %d 0x%.2x%.2x%.2x 0x%.4x %d %d %u\n", | 407 | seq_printf(f, "%s %d %d %d 0x%.2x%.2x%.2x 0x%.4x %d %d %u\n", |
414 | batostr(&bdaddr), | 408 | batostr(&data->bdaddr), |
415 | data->pscan_rep_mode, data->pscan_period_mode, | 409 | data->pscan_rep_mode, data->pscan_period_mode, |
416 | data->pscan_mode, data->dev_class[2], | 410 | data->pscan_mode, data->dev_class[2], |
417 | data->dev_class[1], data->dev_class[0], | 411 | data->dev_class[1], data->dev_class[0], |
@@ -445,13 +439,10 @@ static int blacklist_show(struct seq_file *f, void *p) | |||
445 | 439 | ||
446 | list_for_each(l, &hdev->blacklist) { | 440 | list_for_each(l, &hdev->blacklist) { |
447 | struct bdaddr_list *b; | 441 | struct bdaddr_list *b; |
448 | bdaddr_t bdaddr; | ||
449 | 442 | ||
450 | b = list_entry(l, struct bdaddr_list, list); | 443 | b = list_entry(l, struct bdaddr_list, list); |
451 | 444 | ||
452 | baswap(&bdaddr, &b->bdaddr); | 445 | seq_printf(f, "%s\n", batostr(&b->bdaddr)); |
453 | |||
454 | seq_printf(f, "%s\n", batostr(&bdaddr)); | ||
455 | } | 446 | } |
456 | 447 | ||
457 | hci_dev_unlock_bh(hdev); | 448 | hci_dev_unlock_bh(hdev); |