diff options
author | Andrei Emeltchenko <andrei.emeltchenko@nokia.com> | 2011-01-11 10:20:20 -0500 |
---|---|---|
committer | Gustavo F. Padovan <padovan@profusion.mobi> | 2011-02-07 22:40:08 -0500 |
commit | 5a08eccedaa1e12b74cf3afea9e11a9aefc29f73 (patch) | |
tree | 9bc0f14ce8785a32cf1d4cf4ebf1c297312fada8 /net/bluetooth/cmtp | |
parent | 17fa4b9dff72fb3a1a68cc80caf98fc941d2b8b3 (diff) |
Bluetooth: Do not use assignments in IF conditions
Fix checkpatch warnings concerning assignments in if conditions.
Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@nokia.com>
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
Diffstat (limited to 'net/bluetooth/cmtp')
-rw-r--r-- | net/bluetooth/cmtp/capi.c | 3 | ||||
-rw-r--r-- | net/bluetooth/cmtp/core.c | 9 |
2 files changed, 8 insertions, 4 deletions
diff --git a/net/bluetooth/cmtp/capi.c b/net/bluetooth/cmtp/capi.c index 3487cfe74aec..67cff810c77d 100644 --- a/net/bluetooth/cmtp/capi.c +++ b/net/bluetooth/cmtp/capi.c | |||
@@ -155,7 +155,8 @@ static void cmtp_send_interopmsg(struct cmtp_session *session, | |||
155 | 155 | ||
156 | BT_DBG("session %p subcmd 0x%02x appl %d msgnum %d", session, subcmd, appl, msgnum); | 156 | BT_DBG("session %p subcmd 0x%02x appl %d msgnum %d", session, subcmd, appl, msgnum); |
157 | 157 | ||
158 | if (!(skb = alloc_skb(CAPI_MSG_BASELEN + 6 + len, GFP_ATOMIC))) { | 158 | skb = alloc_skb(CAPI_MSG_BASELEN + 6 + len, GFP_ATOMIC); |
159 | if (!skb) { | ||
159 | BT_ERR("Can't allocate memory for interoperability packet"); | 160 | BT_ERR("Can't allocate memory for interoperability packet"); |
160 | return; | 161 | return; |
161 | } | 162 | } |
diff --git a/net/bluetooth/cmtp/core.c b/net/bluetooth/cmtp/core.c index 8e5f292529ac..2cee71a714c4 100644 --- a/net/bluetooth/cmtp/core.c +++ b/net/bluetooth/cmtp/core.c | |||
@@ -115,7 +115,8 @@ static inline void cmtp_add_msgpart(struct cmtp_session *session, int id, const | |||
115 | 115 | ||
116 | size = (skb) ? skb->len + count : count; | 116 | size = (skb) ? skb->len + count : count; |
117 | 117 | ||
118 | if (!(nskb = alloc_skb(size, GFP_ATOMIC))) { | 118 | nskb = alloc_skb(size, GFP_ATOMIC); |
119 | if (!nskb) { | ||
119 | BT_ERR("Can't allocate memory for CAPI message"); | 120 | BT_ERR("Can't allocate memory for CAPI message"); |
120 | return; | 121 | return; |
121 | } | 122 | } |
@@ -216,7 +217,8 @@ static void cmtp_process_transmit(struct cmtp_session *session) | |||
216 | 217 | ||
217 | BT_DBG("session %p", session); | 218 | BT_DBG("session %p", session); |
218 | 219 | ||
219 | if (!(nskb = alloc_skb(session->mtu, GFP_ATOMIC))) { | 220 | nskb = alloc_skb(session->mtu, GFP_ATOMIC); |
221 | if (!nskb) { | ||
220 | BT_ERR("Can't allocate memory for new frame"); | 222 | BT_ERR("Can't allocate memory for new frame"); |
221 | return; | 223 | return; |
222 | } | 224 | } |
@@ -224,7 +226,8 @@ static void cmtp_process_transmit(struct cmtp_session *session) | |||
224 | while ((skb = skb_dequeue(&session->transmit))) { | 226 | while ((skb = skb_dequeue(&session->transmit))) { |
225 | struct cmtp_scb *scb = (void *) skb->cb; | 227 | struct cmtp_scb *scb = (void *) skb->cb; |
226 | 228 | ||
227 | if ((tail = (session->mtu - nskb->len)) < 5) { | 229 | tail = session->mtu - nskb->len; |
230 | if (tail < 5) { | ||
228 | cmtp_send_frame(session, nskb->data, nskb->len); | 231 | cmtp_send_frame(session, nskb->data, nskb->len); |
229 | skb_trim(nskb, 0); | 232 | skb_trim(nskb, 0); |
230 | tail = session->mtu; | 233 | tail = session->mtu; |