aboutsummaryrefslogtreecommitdiffstats
path: root/net/batman-adv
diff options
context:
space:
mode:
authorLinus Lüssing <linus.luessing@web.de>2013-04-19 06:06:56 -0400
committerAntonio Quartulli <ordex@autistici.org>2013-05-28 20:44:55 -0400
commite54c77f08ec62434ac8b24e402aa7b787cf42198 (patch)
tree62b532066b325c5bef1b45e58b36043c71b3ece1 /net/batman-adv
parentd4ff40f683221d46c351cd9ab61f37a6ea5d2444 (diff)
batman-adv: Remove unnecessary INIT_HLIST_NODE() calls
There's no need to for an explicit hlist_node initialization if it is added to a list right away, like it's the case with the hlist_add_head()s here. Signed-off-by: Linus Lüssing <linus.luessing@web.de> Signed-off-by: Marek Lindner <lindner_marek@yahoo.de> Signed-off-by: Antonio Quartulli <ordex@autistici.org>
Diffstat (limited to 'net/batman-adv')
-rw-r--r--net/batman-adv/bat_iv_ogm.c2
-rw-r--r--net/batman-adv/send.c2
2 files changed, 0 insertions, 4 deletions
diff --git a/net/batman-adv/bat_iv_ogm.c b/net/batman-adv/bat_iv_ogm.c
index 5b0a043c47c8..d07323b3e9b8 100644
--- a/net/batman-adv/bat_iv_ogm.c
+++ b/net/batman-adv/bat_iv_ogm.c
@@ -464,8 +464,6 @@ static void batadv_iv_ogm_aggregate_new(const unsigned char *packet_buff,
464 } 464 }
465 skb_reserve(forw_packet_aggr->skb, ETH_HLEN); 465 skb_reserve(forw_packet_aggr->skb, ETH_HLEN);
466 466
467 INIT_HLIST_NODE(&forw_packet_aggr->list);
468
469 skb_buff = skb_put(forw_packet_aggr->skb, packet_len); 467 skb_buff = skb_put(forw_packet_aggr->skb, packet_len);
470 forw_packet_aggr->packet_len = packet_len; 468 forw_packet_aggr->packet_len = packet_len;
471 memcpy(skb_buff, packet_buff, packet_len); 469 memcpy(skb_buff, packet_buff, packet_len);
diff --git a/net/batman-adv/send.c b/net/batman-adv/send.c
index ed7072ad84e8..ce69f458a754 100644
--- a/net/batman-adv/send.c
+++ b/net/batman-adv/send.c
@@ -152,8 +152,6 @@ _batadv_add_bcast_packet_to_list(struct batadv_priv *bat_priv,
152 struct batadv_forw_packet *forw_packet, 152 struct batadv_forw_packet *forw_packet,
153 unsigned long send_time) 153 unsigned long send_time)
154{ 154{
155 INIT_HLIST_NODE(&forw_packet->list);
156
157 /* add new packet to packet list */ 155 /* add new packet to packet list */
158 spin_lock_bh(&bat_priv->forw_bcast_list_lock); 156 spin_lock_bh(&bat_priv->forw_bcast_list_lock);
159 hlist_add_head(&forw_packet->list, &bat_priv->forw_bcast_list); 157 hlist_add_head(&forw_packet->list, &bat_priv->forw_bcast_list);