diff options
author | Antonio Quartulli <antonio@meshcoding.com> | 2014-09-01 08:37:25 -0400 |
---|---|---|
committer | Antonio Quartulli <antonio@meshcoding.com> | 2015-01-07 11:21:55 -0500 |
commit | 24820df1449d4d7cf71bb66e7885ab7394c7b4fb (patch) | |
tree | 0e20b048e4c08ab73eec5ced36d0da194a85d2ee /net/batman-adv | |
parent | a0e287750562969db8a891e9805fef55aeb05df0 (diff) |
batman-adv: checkpatch - else is not generally useful after a break or return
Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Diffstat (limited to 'net/batman-adv')
-rw-r--r-- | net/batman-adv/bitarray.h | 3 | ||||
-rw-r--r-- | net/batman-adv/fragmentation.h | 3 | ||||
-rw-r--r-- | net/batman-adv/network-coding.c | 3 | ||||
-rw-r--r-- | net/batman-adv/translation-table.c | 5 |
4 files changed, 5 insertions, 9 deletions
diff --git a/net/batman-adv/bitarray.h b/net/batman-adv/bitarray.h index cc2407351d36..2acaafe60188 100644 --- a/net/batman-adv/bitarray.h +++ b/net/batman-adv/bitarray.h | |||
@@ -29,8 +29,7 @@ static inline int batadv_test_bit(const unsigned long *seq_bits, | |||
29 | diff = last_seqno - curr_seqno; | 29 | diff = last_seqno - curr_seqno; |
30 | if (diff < 0 || diff >= BATADV_TQ_LOCAL_WINDOW_SIZE) | 30 | if (diff < 0 || diff >= BATADV_TQ_LOCAL_WINDOW_SIZE) |
31 | return 0; | 31 | return 0; |
32 | else | 32 | return test_bit(diff, seq_bits) != 0; |
33 | return test_bit(diff, seq_bits) != 0; | ||
34 | } | 33 | } |
35 | 34 | ||
36 | /* turn corresponding bit on, so we can remember that we got the packet */ | 35 | /* turn corresponding bit on, so we can remember that we got the packet */ |
diff --git a/net/batman-adv/fragmentation.h b/net/batman-adv/fragmentation.h index 5d7a0e66a22b..d848cf6676a2 100644 --- a/net/batman-adv/fragmentation.h +++ b/net/batman-adv/fragmentation.h | |||
@@ -41,8 +41,7 @@ batadv_frag_check_entry(struct batadv_frag_table_entry *frags_entry) | |||
41 | if (!hlist_empty(&frags_entry->head) && | 41 | if (!hlist_empty(&frags_entry->head) && |
42 | batadv_has_timed_out(frags_entry->timestamp, BATADV_FRAG_TIMEOUT)) | 42 | batadv_has_timed_out(frags_entry->timestamp, BATADV_FRAG_TIMEOUT)) |
43 | return true; | 43 | return true; |
44 | else | 44 | return false; |
45 | return false; | ||
46 | } | 45 | } |
47 | 46 | ||
48 | #endif /* _NET_BATMAN_ADV_FRAGMENTATION_H_ */ | 47 | #endif /* _NET_BATMAN_ADV_FRAGMENTATION_H_ */ |
diff --git a/net/batman-adv/network-coding.c b/net/batman-adv/network-coding.c index fab47f1f3ef9..127cc4d7380a 100644 --- a/net/batman-adv/network-coding.c +++ b/net/batman-adv/network-coding.c | |||
@@ -1212,8 +1212,7 @@ static bool batadv_nc_skb_coding_possible(struct sk_buff *skb, | |||
1212 | { | 1212 | { |
1213 | if (BATADV_SKB_CB(skb)->decoded && !batadv_compare_eth(dst, src)) | 1213 | if (BATADV_SKB_CB(skb)->decoded && !batadv_compare_eth(dst, src)) |
1214 | return false; | 1214 | return false; |
1215 | else | 1215 | return true; |
1216 | return true; | ||
1217 | } | 1216 | } |
1218 | 1217 | ||
1219 | /** | 1218 | /** |
diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index 5f59e7f899a0..38a804e1db0a 100644 --- a/net/batman-adv/translation-table.c +++ b/net/batman-adv/translation-table.c | |||
@@ -2769,9 +2769,8 @@ static bool batadv_send_tt_response(struct batadv_priv *bat_priv, | |||
2769 | { | 2769 | { |
2770 | if (batadv_is_my_mac(bat_priv, req_dst)) | 2770 | if (batadv_is_my_mac(bat_priv, req_dst)) |
2771 | return batadv_send_my_tt_response(bat_priv, tt_data, req_src); | 2771 | return batadv_send_my_tt_response(bat_priv, tt_data, req_src); |
2772 | else | 2772 | return batadv_send_other_tt_response(bat_priv, tt_data, req_src, |
2773 | return batadv_send_other_tt_response(bat_priv, tt_data, | 2773 | req_dst); |
2774 | req_src, req_dst); | ||
2775 | } | 2774 | } |
2776 | 2775 | ||
2777 | static void _batadv_tt_update_changes(struct batadv_priv *bat_priv, | 2776 | static void _batadv_tt_update_changes(struct batadv_priv *bat_priv, |